linux-kernel - [PATCH v2 0/2] fsconfig: minor fsparam

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240731-fsconfig-fsparam_fd-fixes-v2-0-e7c472224417@cyphar.com>
Date: Wed, 31 Jul 2024 23:10:26 +1000
From: Aleksa Sarai <cyphar@...har.com>
To: Ian Kent <raven@...maw.net>, Bill O'Donnell <bodonnel@...hat.com>, 
 Christian Brauner <brauner@...nel.org>, Jan Harkes <jaharkes@...cmu.edu>, 
 coda@...cmu.edu, Eric Sandeen <sandeen@...hat.com>, 
 David Howells <dhowells@...hat.com>
Cc: autofs@...r.kernel.org, linux-kernel@...r.kernel.org, 
 codalist@...a.cs.cmu.edu, Aleksa Sarai <cyphar@...har.com>
Subject: [PATCH v2 0/2] fsconfig: minor fsparam_fd fixes

While working on adding an fsparam_fd() argument to cgroupfs, I noticed
that there are only two users of fsparam_fd() and they both seemed to
have minor issues:

* autofs has a missing fput() when using FSCONFIG_SET_FD.
* coda uses fsparam_fd() but it ignores param->file and so ends up
  re-getting the file. This doesn't change the behaviour but it seems
  preferable to have all users of fsparam_fd() have the same logic.

I have tested this logic for the cgroupfs patch but I have only compile
tested the fixes for autofs and coda.

The second patch is not really required, so feel free to drop it if you
feel the original version was cleaner.

Signed-off-by: Aleksa Sarai <cyphar@...har.com>
---
Changes in v2:
- Fix fs/coda/inode.c build errors.
- Link to v1: https://lore.kernel.org/r/20240719-fsconfig-fsparam_fd-fixes-v1-0-7ccd315c2ad4@cyphar.com

---
Aleksa Sarai (2):
      autofs: fix missing fput for FSCONFIG_SET_FD
      coda: use param->file for FSCONFIG_SET_FD

 fs/autofs/inode.c |  3 +--
 fs/coda/inode.c   | 43 ++++++++++++++++++++++++++++++-------------
 2 files changed, 31 insertions(+), 15 deletions(-)
---
base-commit: c7b9563b58a77423d4c6e026ff831a69612b02fc
change-id: 20240714-fsconfig-fsparam_fd-fixes-09f2e741c28d

Best regards,
-- 
Aleksa Sarai <cyphar@...har.com>