linux-kernel - Re: [PATCH] x86/setup: Parse the builtin command line before merging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87jzh1663p.ffs@tglx>
Date: Wed, 31 Jul 2024 15:31:06 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Borislav Petkov <bp@...en8.de>, Mike Lothian <mike@...eburn.co.uk>
Cc: x86-ml <x86@...nel.org>, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/setup: Parse the builtin command line before merging

On Tue, Jul 30 2024 at 17:21, Borislav Petkov wrote:

> On Mon, Jul 22, 2024 at 05:56:08PM +0100, Mike Lothian wrote:
>> That patch does indeed make the warning go away :D
>> 
>> Is there anything else you need from me?
>
> Nah, all good.
>
> Thanks for reporting and testing.
>
> From: "Borislav Petkov (AMD)" <bp@...en8.de>
> Date: Tue, 30 Jul 2024 16:15:12 +0200
> Subject: [PATCH] x86/setup: Parse the builtin command line before merging
>
> Commit in Fixes was added as a catch-all for cases where the cmdline is
> parsed before being merged with the builtin one.
>
> And promptly one issue appeared, see Link below. And the microcode
> loader really needs to parse it that early. And the merging happens
> late. Reshuffling the early boot nightmare^W code to handle that
> properly would be a painful exercise for another day so do the chicken
> thing and parse the builtin cmdline too before it has been merged.
>
> Fixes: 0c40b1c7a897 ("x86/setup: Warn when option parsing is done too early")
> Reported-by: Mike Lothian <mike@...eburn.co.uk>
> Signed-off-by: Borislav Petkov (AMD) <bp@...en8.de>
> Link: https://lore.kernel.org/r/20240722152330.GCZp55ck8E_FT4kPnC@fat_crate.local

Reviewed-by: Thomas Gleixner <tglx@...utronix.de>