linux-kernel - Re: [PATCH 07/10] platform/x86: fujitsu-laptop: Use backlight power constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zqo6VfQGyApMdTWN@marvin.atrad.com.au>
Date: Wed, 31 Jul 2024 22:51:25 +0930
From: Jonathan Woithe <jwoithe@...t42.net>
To: Thomas Zimmermann <tzimmermann@...e.de>
Cc: hdegoede@...hat.com, ilpo.jarvinen@...ux.intel.com,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/10] platform/x86: fujitsu-laptop: Use backlight power
 constants

On Wed, Jul 31, 2024 at 02:50:57PM +0200, Thomas Zimmermann wrote:
> Replace FB_BLANK_ constants with their counterparts from the
> backlight subsystem. The values are identical, so there's no
> change in functionality or semantics.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@...e.de>
> Cc: Jonathan Woithe <jwoithe@...t42.net>
> Cc: Hans de Goede <hdegoede@...hat.com>
> Cc: "Ilpo Järvinen" <ilpo.jarvinen@...ux.intel.com>

I see no issues as far as fujitsu-laptop is concerned.

Acked-by: Jonathan Woithe <jwoithe@...t42.net>

Regards
  jonathan

> ---
>  drivers/platform/x86/fujitsu-laptop.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index 968fc91bd5e4..ae992ac1ab4a 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -43,7 +43,6 @@
>  #include <linux/bitops.h>
>  #include <linux/dmi.h>
>  #include <linux/backlight.h>
> -#include <linux/fb.h>
>  #include <linux/input.h>
>  #include <linux/input/sparse-keymap.h>
>  #include <linux/kfifo.h>
> @@ -356,7 +355,7 @@ static int bl_get_brightness(struct backlight_device *b)
>  {
>  	struct acpi_device *device = bl_get_data(b);
>  
> -	return b->props.power == FB_BLANK_POWERDOWN ? 0 : get_lcd_level(device);
> +	return b->props.power == BACKLIGHT_POWER_OFF ? 0 : get_lcd_level(device);
>  }
>  
>  static int bl_update_status(struct backlight_device *b)
> @@ -364,7 +363,7 @@ static int bl_update_status(struct backlight_device *b)
>  	struct acpi_device *device = bl_get_data(b);
>  
>  	if (fext) {
> -		if (b->props.power == FB_BLANK_POWERDOWN)
> +		if (b->props.power == BACKLIGHT_POWER_OFF)
>  			call_fext_func(fext, FUNC_BACKLIGHT, 0x1,
>  				       BACKLIGHT_PARAM_POWER, BACKLIGHT_OFF);
>  		else
> @@ -933,9 +932,9 @@ static int acpi_fujitsu_laptop_add(struct acpi_device *device)
>  	    acpi_video_get_backlight_type() == acpi_backlight_vendor) {
>  		if (call_fext_func(fext, FUNC_BACKLIGHT, 0x2,
>  				   BACKLIGHT_PARAM_POWER, 0x0) == BACKLIGHT_OFF)
> -			fujitsu_bl->bl_device->props.power = FB_BLANK_POWERDOWN;
> +			fujitsu_bl->bl_device->props.power = BACKLIGHT_POWER_OFF;
>  		else
> -			fujitsu_bl->bl_device->props.power = FB_BLANK_UNBLANK;
> +			fujitsu_bl->bl_device->props.power = BACKLIGHT_POWER_ON;
>  	}
>  
>  	ret = acpi_fujitsu_laptop_input_setup(device);
> -- 
> 2.45.2

--