[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6163500e4457715e04d520b7287517acf2ab1dc7.camel@mediatek.com>
Date: Wed, 31 Jul 2024 13:41:10 +0000
From: Shun-Yi Wang (王順億) <Shun-Yi.Wang@...iatek.com>
To: "robh@...nel.org" <robh@...nel.org>, "mathieu.poirier@...aro.org"
<mathieu.poirier@...aro.org>, "andersson@...nel.org" <andersson@...nel.org>,
"krzk@...nel.org" <krzk@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
"linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
Jason-ch Chen (陳建豪)
<Jason-ch.Chen@...iatek.com>, Yaya Chang (張雅清)
<Yaya.Chang@...iatek.com>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@...iatek.com>,
Teddy Chen (陳乾元) <Teddy.Chen@...iatek.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
<matthias.bgg@...il.com>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
"angelogioacchino.delregno@...labora.com"
<angelogioacchino.delregno@...labora.com>,
TingHan Shen (沈廷翰) <TingHan.Shen@...iatek.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: remoteproc: Support multiple reserved
memory regions
Hi Krzysztof,
Thanks for the reviews.
On Wed, 2024-07-31 at 14:40 +0200, Krzysztof Kozlowski wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On 31/07/2024 14:17, Shun-yi Wang wrote:
> > From: "shun-yi.wang" <shun-yi.wang@...iatek.com>
> >
> > Remove the maximum number of 1 for memory regions.
>
> Why?
>
For future applications, MTK SCP will reserve multiple regions for
specific hardware use.
> > Instead, add some descriptions to ensure the integrity
> > of the documentation.
>
> What? How is this related?
>
My original thinking was to keep the memory-region option.
But currently, there is no maximum value limitation, so I
add some description. Should I just drop the description directly?
Best regards,
Shun-yi
> >
> > Signed-off-by: shun-yi.wang <shun-yi.wang@...iatek.com>
> > ---
> > Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 8
> ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git
> a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > index d05d1563ec19..3362c8ffdccc 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > @@ -55,7 +55,9 @@ properties:
> > initializing SCP.
> >
> > memory-region:
> > - maxItems: 1
>
> No, no, no. Bindings must be specific/constrainted.
>
> > + description:
> > + List of phandles to the reserved memory nodes used by
> > + remoteproc devices.
>
> No, drop, it's entirely redundant and pointless. You did not add any
> new
> information. This is always a list, always phandles and always
> reserved
> memory regions. So what does it bring?
>
> Please do not upstream random junk from your downstream kernel. :(
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists