linux-kernel - [PATCH] ARM: smp: Fix missing backtrace IPI statics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240801094022.1402616-1-ruanjinjie@huawei.com>
Date: Thu, 1 Aug 2024 17:40:22 +0800
From: Jinjie Ruan <ruanjinjie@...wei.com>
To: <linux@...linux.org.uk>, <dianders@...omium.org>, <mhocko@...e.com>,
	<akpm@...ux-foundation.org>, <maz@...nel.org>, <vschneid@...hat.com>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
CC: <ruanjinjie@...wei.com>
Subject: [PATCH] ARM: smp: Fix missing backtrace IPI statics

It is similar to ARM64 commit 916b93f4e865 ("arm64: smp: Fix missing IPI
statistics"), commit 56afcd3dbd19 ("ARM: Allow IPIs to be handled as normal
interrupts") set CPU_BACKTRACE IPI "IRQ_HIDDEN" flag but not show it in
show_ipi_list(), which cause the interrupt kstat_irqs accounting
is missing in display.

Before this patch, CPU_BACKTRACE IPI is missing (QEMU vexpress-a9):
	 # cat /proc/interrupts
	           CPU0
	 24:          6 GIC-0  34 Level     timer
	 25:        455 GIC-0  29 Level     twd
	 26:         42 GIC-0  75 Edge      virtio0
	 29:          8 GIC-0  44 Level     kmi-pl050
	 30:        118 GIC-0  45 Level     kmi-pl050
	 31:          0 GIC-0  36 Level     rtc-pl031
	 32:          0 GIC-0  41 Level     mmci-pl18x (cmd)
	 33:          0 GIC-0  42 Level     mmci-pl18x (pio)
	 34:          0 GIC-0  92 Level     arm-pmu
	 35:          0 GIC-0  93 Level     arm-pmu
	 36:          0 GIC-0  94 Level     arm-pmu
	 37:          0 GIC-0  95 Level     arm-pmu
	 39:         15 GIC-0  37 Level     uart-pl011
	IPI0:          0  CPU wakeup interrupts
	IPI1:          0  Timer broadcast interrupts
	IPI2:          0  Rescheduling interrupts
	IPI3:          0  Function call interrupts
	IPI4:          0  CPU stop interrupts
	IPI5:          0  IRQ work interrupts
	IPI6:          0  completion interrupts
	Err:          0

After this pacth, CPU_BACKTRACE IPI is displayed:
	 # cat /proc/interrupts
	           CPU0
	 24:          6 GIC-0  34 Level     timer
	 25:        687 GIC-0  29 Level     twd
	 26:         42 GIC-0  75 Edge      virtio0
	 29:          8 GIC-0  44 Level     kmi-pl050
	 30:        134 GIC-0  45 Level     kmi-pl050
	 31:          0 GIC-0  36 Level     rtc-pl031
	 32:          0 GIC-0  41 Level     mmci-pl18x (cmd)
	 33:          0 GIC-0  42 Level     mmci-pl18x (pio)
	 34:          0 GIC-0  92 Level     arm-pmu
	 35:          0 GIC-0  93 Level     arm-pmu
	 36:          0 GIC-0  94 Level     arm-pmu
	 37:          0 GIC-0  95 Level     arm-pmu
	 39:         29 GIC-0  37 Level     uart-pl011
	IPI0:          0  CPU wakeup interrupts
	IPI1:          0  Timer broadcast interrupts
	IPI2:          0  Rescheduling interrupts
	IPI3:          0  Function call interrupts
	IPI4:          0  CPU stop interrupts
	IPI5:          0  IRQ work interrupts
	IPI6:          0  completion interrupts
	IPI7:          0  CPU backtrace interrupts
	Err:          0

Fixes: 56afcd3dbd19 ("ARM: Allow IPIs to be handled as normal interrupts")
Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
---
 arch/arm/kernel/smp.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
index 3431c0553f45..be15cca7f8d7 100644
--- a/arch/arm/kernel/smp.c
+++ b/arch/arm/kernel/smp.c
@@ -531,7 +531,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
 	}
 }
 
-static const char *ipi_types[NR_IPI] __tracepoint_string = {
+static const char *ipi_types[MAX_IPI] __tracepoint_string = {
 	[IPI_WAKEUP]		= "CPU wakeup interrupts",
 	[IPI_TIMER]		= "Timer broadcast interrupts",
 	[IPI_RESCHEDULE]	= "Rescheduling interrupts",
@@ -539,6 +539,7 @@ static const char *ipi_types[NR_IPI] __tracepoint_string = {
 	[IPI_CPU_STOP]		= "CPU stop interrupts",
 	[IPI_IRQ_WORK]		= "IRQ work interrupts",
 	[IPI_COMPLETION]	= "completion interrupts",
+	[IPI_CPU_BACKTRACE]	= "CPU backtrace interrupts"
 };
 
 static void smp_cross_call(const struct cpumask *target, unsigned int ipinr);
@@ -547,7 +548,7 @@ void show_ipi_list(struct seq_file *p, int prec)
 {
 	unsigned int cpu, i;
 
-	for (i = 0; i < NR_IPI; i++) {
+	for (i = 0; i < MAX_IPI; i++) {
 		if (!ipi_desc[i])
 			continue;
 
-- 
2.34.1