[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <00f4f77151de3c3a4964fe697a7d1841c670284b.camel@ginzinger.com>
Date: Thu, 1 Aug 2024 09:52:01 +0000
From: Kepplinger-Novakovic Martin <Martin.Kepplinger-Novakovic@...zinger.com>
To: "u.kleine-koenig@...libre.com" <u.kleine-koenig@...libre.com>
CC: "daniel.thompson@...aro.org" <daniel.thompson@...aro.org>,
"lee@...nel.org" <lee@...nel.org>, "linux-pwm@...r.kernel.org"
<linux-pwm@...r.kernel.org>, "jingoohan1@...il.com" <jingoohan1@...il.com>,
"linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] backlight: pwm_bl: print errno for probe errors
Am Donnerstag, dem 01.08.2024 um 11:26 +0200 schrieb Uwe Kleine-König:
> Hello Martin,
>
> On Thu, Aug 01, 2024 at 11:12:55AM +0200, Martin Kepplinger-Novaković
> wrote:
> > This makes debugging often easier.
> >
> > Signed-off-by: Martin Kepplinger-Novaković
> > <martin.kepplinger-novakovic@...zinger.com>
> > ---
> > drivers/video/backlight/pwm_bl.c | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/video/backlight/pwm_bl.c
> > b/drivers/video/backlight/pwm_bl.c
> > index f1005bd0c41e3..cc7e7af71891f 100644
> > --- a/drivers/video/backlight/pwm_bl.c
> > +++ b/drivers/video/backlight/pwm_bl.c
> > @@ -502,7 +502,8 @@ static int pwm_backlight_probe(struct
> > platform_device *pdev)
> > GPIOD_ASIS);
> > if (IS_ERR(pb->enable_gpio)) {
> > ret = dev_err_probe(&pdev->dev, PTR_ERR(pb-
> > >enable_gpio),
> > - "failed to acquire enable
> > GPIO\n");
> > + "failed to acquire enable GPIO:
> > %ld\n",
> > + PTR_ERR(pb->enable_gpio));
>
> AFAIK dev_err_probe already emits the error code passed as 2nd
> parameter. So I wonder about this patch's benefit.
>
It does. Other messages only take the deferred_probe_reason without the
error code. It's actually fine if users properly enable debugging after
seeing an error and then this change is not needed :)
thanks,
martin
Download attachment "smime.p7s" of type "application/pkcs7-signature" (7522 bytes)
Powered by blists - more mailing lists