linux-kernel - RE: [PATCH v11 2/6] media: videodev2.h: add visconti viif meta buffer format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <OSZPR01MB942779F5FF6F97FB01F03F7D92B22@OSZPR01MB9427.jpnprd01.prod.outlook.com>
Date: Thu, 1 Aug 2024 09:20:35 +0000
From: <yuji2.ishikawa@...hiba.co.jp>
To: <laurent.pinchart@...asonboard.com>
CC: <hverkuil@...all.nl>, <mchehab@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>, <broonie@...nel.org>,
        <sakari.ailus@...ux.intel.com>, <nobuhiro1.iwamatsu@...hiba.co.jp>,
        <linux-media@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v11 2/6] media: videodev2.h: add visconti viif meta buffer
 format

Hello Laurent,

Thank you for your review comments.

> -----Original Message-----
> From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Sent: Tuesday, July 23, 2024 12:12 AM
> To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開)
> <yuji2.ishikawa@...hiba.co.jp>
> Cc: Hans Verkuil <hverkuil@...all.nl>; Mauro Carvalho Chehab
> <mchehab@...nel.org>; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski
> <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Mark Brown
> <broonie@...nel.org>; Sakari Ailus <sakari.ailus@...ux.intel.com>; iwamatsu
> nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ)
> <nobuhiro1.iwamatsu@...hiba.co.jp>; linux-media@...r.kernel.org;
> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v11 2/6] media: videodev2.h: add visconti viif meta buffer
> format
> 
> On Mon, Jul 22, 2024 at 06:10:37PM +0300, Laurent Pinchart wrote:
> > Hi Ishikawa-san,
> >
> > Thank you for the patch.
> >
> > On Tue, Jul 09, 2024 at 09:08:44AM +0900, Yuji Ishikawa wrote:
> > > Adds the Toshiba Visconti VIIF specific metadata format
> > >
> > > - V4L2_META_FMT_VISCONTI_VIIF_PARAMS for ISP parameters
> > > - V4L2_META_FMT_VISCONTI_VIIF_STATS for ISP statistics
> > >
> > > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@...hiba.co.jp>
> >
> > This patch looks fine. Assuming the corresponding documentation patch
> > is fine too,
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> 
> Actually I spoke a bit too fast, you need to update
> drivers/media/v4l2-core/v4l2-ioctl.c with the two new formats. See commit
> 8f6c2202222fa for an example.
> 

I'll add some operations to v4l_fill_fmtdesc() as described in the specified patch.

> > > ---
> > > Changelog v10:
> > > - add entry for V4L2_META_FMT_VISCONTI_VIIF_PARAMS
> > > - add entry for V4L2_META_FMT_VISCONTI_VIIF_STATS
> > >
> > > Changelog v11:
> > > - no change
> > >
> > >  include/uapi/linux/videodev2.h | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/include/uapi/linux/videodev2.h
> > > b/include/uapi/linux/videodev2.h index 4e91362da6..562038f144 100644
> > > --- a/include/uapi/linux/videodev2.h
> > > +++ b/include/uapi/linux/videodev2.h
> > > @@ -858,6 +858,10 @@ struct v4l2_pix_format {
> > >  /* Vendor specific - used for RaspberryPi PiSP */
> > >  #define V4L2_META_FMT_RPI_BE_CFG	v4l2_fourcc('R', 'P', 'B', 'C') /*
> PiSP BE configuration */
> > >
> > > +/* Vendor specific - used for Visconti VIIF sub-system */
> > > +#define V4L2_META_FMT_VISCONTI_VIIF_PARAMS
> 	v4l2_fourcc('V', 'I', 'F', 'P') /* ISP Params */
> > > +#define V4L2_META_FMT_VISCONTI_VIIF_STATS	v4l2_fourcc('V', 'I', 'F',
> 'S') /* ISP Stats */
> > > +
> > >  #ifdef __KERNEL__
> > >  /*
> > >   * Line-based metadata formats. Remember to update
> > > v4l_fill_fmtdesc() when
> 
> --
> Regards,
> 
> Laurent Pinchart

Regards,
Yuji Ishikawa