linux-kernel - Re: [RFC PATCH net-next v6 12/14] vsock/loopback: implement datagram support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AS2P194MB2170C5B197652F909252BA809AB22@AS2P194MB2170.EURP194.PROD.OUTLOOK.COM>
Date: Thu,  1 Aug 2024 14:18:10 +0200
From: Luigi Leonardi <luigi.leonardi@...look.com>
To: ameryhung@...il.com
Cc: amery.hung@...edance.com,
	bobby.eshleman@...edance.com,
	bpf@...r.kernel.org,
	bryantan@...are.com,
	dan.carpenter@...aro.org,
	davem@...emloft.net,
	decui@...rosoft.com,
	edumazet@...gle.com,
	haiyangz@...rosoft.com,
	jasowang@...hat.com,
	jiang.wang@...edance.com,
	kuba@...nel.org,
	kvm@...r.kernel.org,
	kys@...rosoft.com,
	linux-hyperv@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	mst@...hat.com,
	netdev@...r.kernel.org,
	oxffffaa@...il.com,
	pabeni@...hat.com,
	pv-drivers@...are.com,
	sgarzare@...hat.com,
	simon.horman@...igine.com,
	stefanha@...hat.com,
	vdasa@...are.com,
	virtualization@...ts.linux-foundation.org,
	wei.liu@...nel.org,
	xiyou.wangcong@...il.com,
	xuanzhuo@...ux.alibaba.com,
	Luigi Leonardi <luigi.leonardi@...look.com>
Subject: Re: [RFC PATCH net-next v6 12/14] vsock/loopback: implement datagram support

> +static bool vsock_loopback_dgram_allow(u32 cid, u32 port)
> +{
> +	return true;
> +}
> +
>  static bool vsock_loopback_seqpacket_allow(u32 remote_cid);
>  static bool vsock_loopback_msgzerocopy_allow(void)
>  {
> @@ -66,7 +71,7 @@ static struct virtio_transport loopback_transport = {
>  		.cancel_pkt               = vsock_loopback_cancel_pkt,
>
>  		.dgram_enqueue            = virtio_transport_dgram_enqueue,
> -		.dgram_allow              = virtio_transport_dgram_allow,
> +		.dgram_allow              = vsock_loopback_dgram_allow,
>
>  		.stream_dequeue           = virtio_transport_stream_dequeue,
>  		.stream_enqueue           = virtio_transport_stream_enqueue,
> --
> 2.20.1

Code LGTM! Just because you have to send a new version I'd modify
the commit message to something like:
"Add 'vsock_loopback_dgram_allow' callback for datagram support."

Feel free to change it :)

Thank you,
Luigi