linux-kernel - Re: [PATCH v2] phy: fsl-imx8mq-usb: fix tuning parameter name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240801124254.36sabvfg33kb4f2e@hippo>
Date: Thu, 1 Aug 2024 20:42:54 +0800
From: Xu Yang <xu.yang_2@....com>
To: Alexander Stein <alexander.stein@...tq-group.com>
Cc: vkoul@...nel.org, kishon@...nel.org, shawnguo@...nel.org,
	s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
	jun.li@....com, linux-phy@...ts.infradead.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] phy: fsl-imx8mq-usb: fix tuning parameter name

On Thu, Aug 01, 2024 at 02:24:15PM +0200, Alexander Stein wrote:
> Hi,
> 
> Am Donnerstag, 1. August 2024, 13:01:36 CEST schrieb Xu Yang:
> > According to fsl,imx8mq-usb-phy.yaml, this tuning parameter should be
> > fsl,phy-pcs-tx-deemph-3p5db-attenuation-db.
> > 
> > Fixes: c971874a89e1 ("phy: fsl-imx8mq-usb: fix tuning parameter name")
> 
> Maybe you accidently selected the wrong commit here. I think this should be
> Fixes: 63c85ad0cd811 ("phy: fsl-imx8mp-usb: add support for phy tuning")

Thank you! I find the commit but wrongly paste another one.

Best Regards,
Xu Yang


> 
> Best regards,
> Alexander
> 
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Xu Yang <xu.yang_2@....com>
> > 
> > ---
> > Changes in v2:
> >  - add fixes
> > ---
> >  drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> > index 0b9a59d5b8f0..adc6394626ce 100644
> > --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> > +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> > @@ -176,7 +176,7 @@ static void imx8m_get_phy_tuning_data(struct imx8mq_usb_phy *imx_phy)
> >  		imx_phy->comp_dis_tune =
> >  			phy_comp_dis_tune_from_property(imx_phy->comp_dis_tune);
> >  
> > -	if (device_property_read_u32(dev, "fsl,pcs-tx-deemph-3p5db-attenuation-db",
> > +	if (device_property_read_u32(dev, "fsl,phy-pcs-tx-deemph-3p5db-attenuation-db",
> >  				     &imx_phy->pcs_tx_deemph_3p5db))
> >  		imx_phy->pcs_tx_deemph_3p5db = PHY_TUNE_DEFAULT;
> >  	else
> > 
> 
> 
> -- 
> TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht München, HRB 105018
> Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> http://www.tq-group.com/
> 
>