linux-kernel - [PATCH -next] md: wake up mdmon after setting badblocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240801125148.251986-1-yukuai1@huaweicloud.com>
Date: Thu,  1 Aug 2024 20:51:48 +0800
From: Yu Kuai <yukuai1@...weicloud.com>
To: song@...nel.org
Cc: linux-raid@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	yukuai3@...wei.com,
	yukuai1@...weicloud.com,
	yi.zhang@...wei.com,
	yangerkun@...wei.com
Subject: [PATCH -next] md: wake up mdmon after setting badblocks

From: Yu Kuai <yukuai3@...wei.com>

For external super_block, mdmon rely on "mddev->sysfs_state" to update
super_block. However, rdev_set_badblocks() will set sb_flags without
waking up mdmon, which might cauing IO hang due to suepr_block can't be
updated.

This problem is found by code review.

Signed-off-by: Yu Kuai <yukuai3@...wei.com>
---
 drivers/md/md.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 23cc77d51676..06d6ee8cd543 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -9831,10 +9831,12 @@ int rdev_set_badblocks(struct md_rdev *rdev, sector_t s, int sectors,
 		/* Make sure they get written out promptly */
 		if (test_bit(ExternalBbl, &rdev->flags))
 			sysfs_notify_dirent_safe(rdev->sysfs_unack_badblocks);
-		sysfs_notify_dirent_safe(rdev->sysfs_state);
 		set_mask_bits(&mddev->sb_flags, 0,
 			      BIT(MD_SB_CHANGE_CLEAN) | BIT(MD_SB_CHANGE_PENDING));
 		md_wakeup_thread(rdev->mddev->thread);
+
+		sysfs_notify_dirent_safe(rdev->sysfs_state);
+		sysfs_notify_dirent_safe(mddev->sysfs_state);
 		return 1;
 	} else
 		return 0;
-- 
2.39.2