linux-kernel - Re: [PATCH 4/9] x86/mce: Move machine_check_poll() status checks to helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240801130420.GCZquH1J8GDDiGUH_X@fat_crate.local>
Date: Thu, 1 Aug 2024 15:04:20 +0200
From: Borislav Petkov <bp@...en8.de>
To: Yazen Ghannam <yazen.ghannam@....com>
Cc: linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
	tony.luck@...el.com, x86@...nel.org, avadhut.naik@....com,
	john.allen@....com
Subject: Re: [PATCH 4/9] x86/mce: Move machine_check_poll() status checks to
 helper functions

On Fri, Jul 26, 2024 at 10:00:30AM -0400, Yazen Ghannam wrote:
> @@ -797,9 +797,11 @@ void machine_check_poll(enum mcp_flags flags, mce_banks_t *b)
> 		if (!mca_cfg.cmci_disabled)
> 			mce_track_storm(&m);
> 
> -               if (!log_poll_error(flags, &m, &status_reg))
> +               /* Verify that the error should be logged based on hardware conditions. */
> +               if (!loggable_poll_error(flags, &m, &status_reg))

Right, or do

		if (!should_log_poll_error(...)

as it becomes maximally readable then - like a plain English sentence.

> 			continue;
> 
> +               /* Clear a loggable error, e.g., one leftover from boot time. */
> 		if (flags & MCP_DONTLOG)
> 			goto clear_it;

So yeah, I guess.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette