linux-kernel - Re: [RFC PATCH net-next 08/10] net: hibmcge: Implement workqueue and some ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <199c085b-a2ed-4d76-bdc6-0f8dde80036d@huawei.com>
Date: Thu, 1 Aug 2024 21:06:10 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Andrew Lunn <andrew@...n.ch>
CC: <shaojijie@...wei.com>, <yisen.zhuang@...wei.com>,
	<salil.mehta@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <horms@...nel.org>,
	<shenjian15@...wei.com>, <wangpeiyang1@...wei.com>, <liuyonglong@...wei.com>,
	<sudongming1@...wei.com>, <xujunsheng@...wei.com>, <shiyongbang@...wei.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH net-next 08/10] net: hibmcge: Implement workqueue and
 some ethtool_ops functions


on 2024/8/1 20:26, Andrew Lunn wrote:
>>> Why do you need this? phylib will poll the PHY once per second and
>>> call the adjust_link callback whenever the link changes state.
>> However, we hope that the network port can be linked only when
>> the PHY and MAC are linked.
>> The adjust_link callback can ensure that the PHY status is normal,
>> but cannot ensure that the MAC address is linked.
> So why would the SGMII link be down? My experience with SGMII is that
> the link comes up as soon as both ends have power. You are also not
> using in-band signalling, you configure the MAC based on the
> adjust_link callback.
>
> Basically, whenever you do something which no other driver does, you
> need to explain why. Do you see any other MAC driver using SGMII doing
> this?
>
> 	Andrew

Yes, it was my mistake, I should explain why.


If the network port is linked, but the link fails between the SGMII and PHY,
is there any method to find out the cause?

I've had a problem with phy link but SGMII no link due to poor contact.
In this case, the network port no link. Therefore, we can quickly find and analyze the cause.

Or maybe we shouldn't think about the case. because the link is up but packets cannot be received or sent.

Thanks

Jijie Shao