| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20240801132714.GA8783@redhat.com> Date: Thu, 1 Aug 2024 15:27:14 +0200 From: Oleg Nesterov <oleg@...hat.com> To: andrii@...nel.org, mhiramat@...nel.org, peterz@...radead.org Cc: jolsa@...nel.org, rostedt@...dmis.org, linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org Subject: [PATCH v4 2/9] uprobes: is_trap_at_addr: don't use get_user_pages_remote() get_user_pages_remote() and the comment above it make no sense. There is no task_struct passed into get_user_pages_remote() anymore, and nowadays mm_account_fault() increments the current->min/maj_flt counters regardless of FAULT_FLAG_REMOTE. Reported-by: Andrii Nakryiko <andrii@...nel.org> Signed-off-by: Oleg Nesterov <oleg@...hat.com> Acked-by: Andrii Nakryiko <andrii@...nel.org> Reviewed-by: Jiri Olsa <jolsa@...nel.org> --- kernel/events/uprobes.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index 73dd12b09a7b..eb71428691bb 100644 --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c @@ -2035,13 +2035,7 @@ static int is_trap_at_addr(struct mm_struct *mm, unsigned long vaddr) if (likely(result == 0)) goto out; - /* - * The NULL 'tsk' here ensures that any faults that occur here - * will not be accounted to the task. 'mm' *is* current->mm, - * but we treat this as a 'remote' access since it is - * essentially a kernel access to the memory. - */ - result = get_user_pages_remote(mm, vaddr, 1, FOLL_FORCE, &page, NULL); + result = get_user_pages(vaddr, 1, FOLL_FORCE, &page); if (result < 0) return result; -- 2.25.1.362.g51ebf55
Powered by blists - more mailing lists