linux-kernel - Re: [PATCH 2/2] i3c: master: Add Nuvoton npcm845 i3c master driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ae62cf-172c-4058-b911-e327dfbd5af2@kernel.org>
Date: Thu, 1 Aug 2024 17:02:38 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: James Chiang <cpchiang1@...oton.com>, Stanley Chu <yschu@...oton.com>,
 linux-i3c@...ts.infradead.org, openbmc@...ts.ozlabs.org,
 devicetree@...r.kernel.org, Alexandre Belloni
 <alexandre.belloni@...tlin.com>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Rob Herring <robh@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Joseph Liu <kwliu@...oton.com>,
 Tomer Maimon <tomer.maimon@...oton.com>
Subject: Re: [PATCH 2/2] i3c: master: Add Nuvoton npcm845 i3c master driver

On 01/08/2024 10:42, Markus Elfring wrote:
> …
>> +++ b/drivers/i3c/master/npcm845-i3c-master.c
>> @@ -0,0 +1,2364 @@
> …
>> +static int npcm_i3c_master_do_daa(struct i3c_master_controller *m)
>> +{
> …
>> +	int ret, i;
>> +
>> +	mutex_lock(&master->lock);
>> +	spin_lock_irqsave(&master->req_lock, flags);
> …
>> +	npcm_i3c_master_set_sda_skew(master, 0);
>> +	spin_unlock_irqrestore(&master->req_lock, flags);
>> +	mutex_unlock(&master->lock);
> …
> 
> Under which circumstances would you become interested to apply statements
> like the following?

<form letter>
Feel free to ignore all comments from Markus, regardless whether the
suggestion is reasonable or not. This person is banned from LKML and
several maintainers ignore Markus' feedback, because it is just a waste
of time.
</form letter>

Best regards,
Krzysztof