linux-kernel - Re: [v2] perf arch events: Fix duplicate RISC-V SBI firmware event name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fUJh6zzpiFcYwxMjxk7O3eOZWTVvzOB_zt+twcbnZMYXA@mail.gmail.com>
Date: Thu, 1 Aug 2024 08:26:24 -0700
From: Ian Rogers <irogers@...gle.com>
To: Atish Patra <atishp@...osinc.com>
Cc: eric.lin@...ive.com, peterz@...radead.org, mingo@...hat.com, 
	acme@...nel.org, namhyung@...nel.org, alexander.shishkin@...ux.intel.com, 
	jolsa@...nel.org, palmer@...belt.com, aou@...s.berkeley.edu, 
	peterlin@...estech.com, dminus@...estech.com, locus84@...estech.com, 
	jisheng.teoh@...rfivetech.com, inochiama@...look.com, n.shubin@...ro.com, 
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-riscv@...ts.infradead.org, Samuel Holland <samuel.holland@...ive.com>
Subject: Re: [v2] perf arch events: Fix duplicate RISC-V SBI firmware event name

On Mon, Jul 29, 2024 at 11:19 AM Atish Patra <atishp@...osinc.com> wrote:
>
> > Currently, the RISC-V firmware JSON file has duplicate event name
> > "FW_SFENCE_VMA_RECEIVED". According to the RISC-V SBI PMU extension[1],
> > the event name should be "FW_SFENCE_VMA_ASID_SENT".
> >
> > Before this patch:
> > $ perf list
> >
> > firmware:
> >   fw_access_load
> >        [Load access trap event. Unit: cpu]
> >   fw_access_store
> >        [Store access trap event. Unit: cpu]
> > ....
> >  fw_set_timer
> >        [Set timer event. Unit: cpu]
> >   fw_sfence_vma_asid_received
> >        [Received SFENCE.VMA with ASID request from other HART event. Unit: cpu]
> >   fw_sfence_vma_received
> >        [Sent SFENCE.VMA with ASID request to other HART event. Unit: cpu]
> >
> > After this patch:
> > $ perf list
> >
> > firmware:
> >   fw_access_load
> >        [Load access trap event. Unit: cpu]
> >   fw_access_store
> >        [Store access trap event. Unit: cpu]
> > .....
> >   fw_set_timer
> >        [Set timer event. Unit: cpu]
> >   fw_sfence_vma_asid_received
> >        [Received SFENCE.VMA with ASID request from other HART event. Unit: cpu]
> >   fw_sfence_vma_asid_sent
> >        [Sent SFENCE.VMA with ASID request to other HART event. Unit: cpu]
> >   fw_sfence_vma_received
> >        [Received SFENCE.VMA request from other HART event. Unit: cpu]
> >
> > Link: https://github.com/riscv-non-isa/riscv-sbi-doc/blob/master/src/ext-pmu.adoc#event-firmware-events-type-15 [1]
> > Fixes: 8f0dcb4e7364 ("perf arch events: riscv sbi firmware std event files")
> > Fixes: c4f769d4093d ("perf vendor events riscv: add Sifive U74 JSON file")
> > Fixes: acbf6de674ef ("perf vendor events riscv: Add StarFive Dubhe-80 JSON file")
> > Fixes: 7340c6df49df ("perf vendor events riscv: add T-HEAD C9xx JSON file")
> > Fixes: f5102e31c209 ("riscv: andes: Support specifying symbolic firmware and hardware raw event")
> > Signed-off-by: Eric Lin <eric.lin@...ive.com>
> > Reviewed-by: Samuel Holland <samuel.holland@...ive.com>
> > Reviewed-by: Nikita Shubin <n.shubin@...ro.com>
> > ---
> > Changes since V1:
> >  - Add "Fixes:" tag for every patch that copied firmware.json
> Reviewed-by: Atish Patra <atishp@...osinc.com>

Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian