linux-kernel - Re: [PATCH] pwm: lp3943: Use of_property_count_u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqK+rF0fTDh5-gQWfmijkBuDOoxJ4M+TVvSpUgWgeOhZBA@mail.gmail.com>
Date: Thu, 1 Aug 2024 09:52:18 -0600
From: Rob Herring <robh@...nel.org>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pwm: lp3943: Use of_property_count_u32_elems() to get
 property length

On Thu, Aug 1, 2024 at 2:58 AM Uwe Kleine-König
<u.kleine-koenig@...libre.com> wrote:
>
> Hello Rob,
>
> On Wed, Jul 31, 2024 at 02:14:03PM -0600, Rob Herring (Arm) wrote:
> > Replace of_get_property() with the type specific
> > of_property_count_u32_elems() to get the property length.
> >
> > This is part of a larger effort to remove callers of of_get_property()
> > and similar functions. of_get_property() leaks the DT property data
> > pointer which is a problem for dynamically allocated nodes which may
> > be freed.
>
> To understand that right: The problem is that of_get_property() returns
> pp->value, which might be freed. In this driver this isn't problematic
> as the returned value is just used for a NULL check. So this isn't
> urgent and queuing it for the next merge window is fine, right?

Yes, 6.12 is fine.

Rob