linux-kernel - Re: [PATCH V5 8/8] cpufreq: Add Rust based cpufreq-dt driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqJe4W4XV1RwkRRhJ4U=TzhgE5vo6aBsXBWjPzU89dWeAQ@mail.gmail.com>
Date: Thu, 1 Aug 2024 10:05:17 -0600
From: Rob Herring <robh@...nel.org>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Miguel Ojeda <miguel.ojeda.sandonis@...il.com>, 
	Danilo Krummrich <dakr@...hat.com>, Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Wedson Almeida Filho <wedsonaf@...il.com>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...sung.com>, 
	Alice Ryhl <aliceryhl@...gle.com>, linux-pm@...r.kernel.org, 
	Vincent Guittot <vincent.guittot@...aro.org>, Stephen Boyd <sboyd@...nel.org>, 
	Nishanth Menon <nm@...com>, rust-for-linux@...r.kernel.org, 
	Manos Pitsidianakis <manos.pitsidianakis@...aro.org>, Erik Schilling <erik.schilling@...aro.org>, 
	Alex Bennée <alex.bennee@...aro.org>, 
	Joakim Bech <joakim.bech@...aro.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V5 8/8] cpufreq: Add Rust based cpufreq-dt driver

On Thu, Aug 1, 2024 at 2:31 AM Viresh Kumar <viresh.kumar@...aro.org> wrote:
>
> On 31-07-24, 15:14, Rob Herring wrote:
> > We don't want anything in Rust based on of_find_property() which this
> > is. That function assumes a device node and its properties are never
> > freed which is no longer a valid assumption (since OF_DYNAMIC and then
> > overlays). There's some work starting to address that, and my plan is
> > using of_find_property() on dynamic nodes will start warning. The
> > of_property_* API mostly avoids that issue (string types are an issue)
>
> Okay. Migrated to of_property_present() now. Thanks.
>
> > Also, it's probably the device property API we want to build Rust
> > bindings on top of rather than DT and ACPI. OTOH, the device property
> > API may be missing some features needed with OPP bindings.
>
> I am not sure which device properties are you talking about. Are there
> any OF related examples available there ?

device_property_*()

Basically a wrapper around fwnode APIs taking struct device rather
than fwnode. While I think the sharing of properties between DT and
ACPI is flawed and converting C drivers from of_property_ to
device_property_ calls is pointless, I think since rust bindings are a
blank page, using the device_property_ API makes sense.

Rob