linux-kernel - Re: [PATCH v2] selftests: openat2: don't print total number of tests and then skip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f560819b-3a3c-4999-ad63-422ca31e9b08@linuxfoundation.org>
Date: Thu, 1 Aug 2024 10:27:04 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>,
 Shuah Khan <shuah@...nel.org>
Cc: Aleksa Sarai <cyphar@...har.com>, kernel@...labora.com,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2] selftests: openat2: don't print total number of tests
 and then skip

On 8/1/24 02:42, Muhammad Usama Anjum wrote:
> On 7/31/24 9:57 PM, Shuah Khan wrote:
>> On 7/31/24 07:39, Muhammad Usama Anjum wrote:
>>> Don't print that 88 sub-tests are going to be executed, but then skip.
>>> This is against TAP compliance. Instead check pre-requisites first
>>> before printing total number of tests.
>>
>> Does TAP clearly mention this?
> Yes from https://testanything.org/tap-version-13-specification.html
> 
> Skipping everything
> This listing shows that the entire listing is a skip. No tests were run.
> 
> TAP version 13
> 1..0 # skip because English-to-French translator isn't installed

I don't see how this is applicable to the current scenario. The user
needs to have root privilege to run the test.

It is important to mention how many tests could have been run.
As mentioned before, this information is important for users and testers.

I would like to see this information in the output.

> 
> We can see above that we need to print 1..0 and skip without printing the
> total number of tests to be executed as they are going to be skipped.
> 
>>
>>>
>>> Old non-tap compliant output:
>>>     TAP version 13
>>>     1..88
>>>     ok 2 # SKIP all tests require euid == 0
>>>     # Planned tests != run tests (88 != 1)>>>     # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:1 error:0
>>>
>>> New and correct output:
>>>     TAP version 13
>>>     1..0 # SKIP all tests require euid == 0
>>
>> The problem is that this new output doesn't show how many tests
>> are in this test suite that could be run.
>>
>> I am not use if this is better for communicating coverage information
>> even if meets the TAP compliance.
> I think the number of tests represents the number of planned tests. If we
> don't plan to run X number of tests, we shouldn't print it.

88 tests are planned to be run except for the fact the first check
failed.

Planned tests could not be run because of user privileges. So these
tests are all skips because of unmet dependencies.

So the a good report would show that 88 tests could have been run. You
can meet the specification and still make it work for us. When we
adapt TAP 13 we didn't require 100% compliance.

There are cases where you can comply and still provide how many test
could be run.

I think you are applying the spec strictly thereby removing useful
information from the report.

Can you tell me what would fail because of this "non-compliance"?

thanks,
-- Shuah