linux-kernel - Re: [PATCH 07/10] ntb: idt: Replace deprecated PCI functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <gxl6trxfwcjsjbte5pg3334iqxofh2kau4fsfovdptibnng3jl@332tt4vrpo3o>
Date: Thu, 1 Aug 2024 20:56:02 +0300
From: Serge Semin <fancer.lancer@...il.com>
To: Philipp Stanner <pstanner@...hat.com>
Cc: Jonathan Corbet <corbet@....net>, Damien Le Moal <dlemoal@...nel.org>, 
	Niklas Cassel <cassel@...nel.org>, Giovanni Cabiddu <giovanni.cabiddu@...el.com>, 
	Herbert Xu <herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>, 
	Boris Brezillon <bbrezillon@...nel.org>, Arnaud Ebalard <arno@...isbad.org>, 
	Srujana Challa <schalla@...vell.com>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, 
	Miri Korenblit <miriam.rachel.korenblit@...el.com>, Kalle Valo <kvalo@...nel.org>, Jon Mason <jdmason@...zu.us>, 
	Dave Jiang <dave.jiang@...el.com>, Allen Hubbe <allenbh@...il.com>, 
	Bjorn Helgaas <bhelgaas@...gle.com>, Kevin Cernekee <cernekee@...il.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jirislaby@...nel.org>, 
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Mark Brown <broonie@...nel.org>, 
	David Lechner <dlechner@...libre.com>, 
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, Jonathan Cameron <Jonathan.Cameron@...wei.com>, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Jie Wang <jie.wang@...el.com>, 
	Adam Guerin <adam.guerin@...el.com>, Shashank Gupta <shashank.gupta@...el.com>, 
	Damian Muszynski <damian.muszynski@...el.com>, Nithin Dabilpuram <ndabilpuram@...vell.com>, 
	Bharat Bhushan <bbhushan2@...vell.com>, Johannes Berg <johannes.berg@...el.com>, 
	Gregory Greenman <gregory.greenman@...el.com>, Emmanuel Grumbach <emmanuel.grumbach@...el.com>, 
	Yedidya Benshimol <yedidya.ben.shimol@...el.com>, Breno Leitao <leitao@...ian.org>, 
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, John Ogness <john.ogness@...utronix.de>, 
	Thomas Gleixner <tglx@...utronix.de>, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-ide@...r.kernel.org, qat-linux@...el.com, linux-crypto@...r.kernel.org, 
	linux-wireless@...r.kernel.org, ntb@...ts.linux.dev, linux-pci@...r.kernel.org, 
	linux-serial@...r.kernel.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH 07/10] ntb: idt: Replace deprecated PCI functions

Hi Philipp

On Thu, Aug 01, 2024 at 07:46:05PM +0200, Philipp Stanner wrote:
> pcim_iomap_table() and pcim_iomap_regions_request_all() have been
> deprecated by the PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate
> pcim_iomap_table(), pcim_iomap_regions_request_all()").
> 
> Replace these functions with their successors, pcim_iomap() and
> pcim_request_all_regions()
> 
> Signed-off-by: Philipp Stanner <pstanner@...hat.com>

Looking good to me. Thanks.

Acked-by: Serge Semin <fancer.lancer@...il.com>

-Serge(y)

> ---
>  drivers/ntb/hw/idt/ntb_hw_idt.c | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/ntb/hw/idt/ntb_hw_idt.c b/drivers/ntb/hw/idt/ntb_hw_idt.c
> index 48dfb1a69a77..f1b57d51a814 100644
> --- a/drivers/ntb/hw/idt/ntb_hw_idt.c
> +++ b/drivers/ntb/hw/idt/ntb_hw_idt.c
> @@ -2671,15 +2671,20 @@ static int idt_init_pci(struct idt_ntb_dev *ndev)
>  	 */
>  	pci_set_master(pdev);
>  
> -	/* Request all BARs resources and map BAR0 only */
> -	ret = pcim_iomap_regions_request_all(pdev, 1, NTB_NAME);
> +	/* Request all BARs resources */
> +	ret = pcim_request_all_regions(pdev, NTB_NAME);
>  	if (ret != 0) {
>  		dev_err(&pdev->dev, "Failed to request resources\n");
>  		goto err_clear_master;
>  	}
>  
> -	/* Retrieve virtual address of BAR0 - PCI configuration space */
> -	ndev->cfgspc = pcim_iomap_table(pdev)[0];
> +	/* ioremap BAR0 - PCI configuration space */
> +	ndev->cfgspc = pcim_iomap(pdev, 0, 0);
> +	if (!ndev->cfgspc) {
> +		dev_err(&pdev->dev, "Failed to ioremap BAR 0\n");
> +		ret = -ENOMEM;
> +		goto err_clear_master;
> +	}
>  
>  	/* Put the IDT driver data pointer to the PCI-device private pointer */
>  	pci_set_drvdata(pdev, ndev);
> -- 
> 2.45.2
>