linux-kernel - Re: [PATCH v3 8/9] firmware: arm_scmi: Make VirtIO transport a standalone driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZqvhIeZYdsYPtgHV@pluto>
Date: Thu, 1 Aug 2024 20:25:21 +0100
From: Cristian Marussi <cristian.marussi@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Cristian Marussi <cristian.marussi@....com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	arm-scmi@...r.kernel.org, sudeep.holla@....com,
	james.quinlan@...adcom.com, f.fainelli@...il.com,
	vincent.guittot@...aro.org, etienne.carriere@...com,
	peng.fan@....nxp.com, michal.simek@....com, quic_sibis@...cinc.com,
	quic_nkela@...cinc.com, ptosi@...gle.com, dan.carpenter@...aro.org,
	souvik.chakravarty@....com, "Michael S . Tsirkin" <mst@...hat.com>,
	Igor Skalkin <igor.skalkin@...nsynergy.com>,
	Peter Hilber <peter.hilber@...nsynergy.com>
Subject: Re: [PATCH v3 8/9] firmware: arm_scmi: Make VirtIO transport a
 standalone driver

On Wed, Jul 31, 2024 at 08:11:21AM +0200, Krzysztof Kozlowski wrote:
> On 30/07/2024 15:33, Cristian Marussi wrote:
> > Make SCMI VirtIO transport a standalone driver that can be optionally
> > loaded as a module.
> > 
> 
> > -const struct scmi_desc scmi_virtio_desc = {
> > -	.transport_init = virtio_scmi_init,
> > -	.transport_exit = virtio_scmi_exit,
> > -	.ops = &scmi_virtio_ops,
> > -	/* for non-realtime virtio devices */
> > -	.max_rx_timeout_ms = VIRTIO_MAX_RX_TIMEOUT_MS,
> > -	.max_msg = 0, /* overridden by virtio_get_max_msg() */
> > -	.max_msg_size = VIRTIO_SCMI_MAX_MSG_SIZE,
> > -	.atomic_enabled = IS_ENABLED(CONFIG_ARM_SCMI_TRANSPORT_VIRTIO_ATOMIC_ENABLE),
> > -};
> > +MODULE_ALIAS("scmi-transport-virtio");
> 
> Why do you need the alias being almost the same as module name?
> 

My bad, it was just to place some sort of alias...but not useful really.

Thanks for looking at this,
Cristian