linux-kernel - Re: [PATCH v7 2/5] x86/pkeys: Add helper functions to update PKRU on the sigframe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <877cd02dzl.ffs@tglx>
Date: Thu, 01 Aug 2024 22:18:54 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Aruna Ramakrishna <aruna.ramakrishna@...cle.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "x86@...nel.org" <x86@...nel.org>, "dave.hansen@...ux.intel.com"
 <dave.hansen@...ux.intel.com>, Ingo Molnar <mingo@...nel.org>,
 "linux-mm@...ck.org" <linux-mm@...ck.org>, Keith Lucas
 <keith.lucas@...cle.com>, Jeff Xu <jeffxu@...omium.org>,
 "rick.p.edgecombe@...el.com" <rick.p.edgecombe@...el.com>, Jorge Lucangeli
 Obes <jorgelo@...omium.org>, Kees Cook <keescook@...omium.org>,
 "sroettger@...gle.com" <sroettger@...gle.com>, "jannh@...gle.com"
 <jannh@...gle.com>
Subject: Re: [PATCH  v7 2/5] x86/pkeys: Add helper functions to update PKRU
 on the sigframe

On Thu, Aug 01 2024 at 20:14, Aruna Ramakrishna wrote:
>> On Aug 1, 2024, at 1:57 AM, Thomas Gleixner <tglx@...utronix.de> wrote:
>> On Thu, Aug 01 2024 at 06:51, Aruna Ramakrishna wrote:
>>> 
>>> +extern void __user *get_xsave_addr_user(struct xregs_state *xsave, int xfeature_nr);
>> 
>>  *xsave lacks __user
>> 
> Did you get a chance to review the rest of the patchset? If you have any
> additional comments/suggestions, I can batch those fixes into v8.

I did not find anything problematic.

If you spin up a V8 you could polish your changelogs a bit and give them
some structure. They mostly consist of one big lump. See:

  https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#changelog

for some examples.

Thanks,

        tglx