linux-kernel - Re: [PATCH v3 0/3] Rework mce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80c5bfdf-e255-48ac-a185-6b8172710c3e@amd.com>
Date: Thu, 1 Aug 2024 16:02:00 -0500
From: Avadhut Naik <avadnaik@....com>
To: Yazen Ghannam <yazen.ghannam@....com>, linux-edac@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, tony.luck@...el.com, x86@...nel.org,
 avadhut.naik@....com, john.allen@....com
Subject: Re: [PATCH v3 0/3] Rework mce_setup()



On 7/30/24 13:29, Yazen Ghannam wrote:
> Hi all,
> 
> This revision drops the topology export idea from v2. It seemed to add
> more complexity than just doing a local search. 
> 
> Thanks,
> Yazen
> 
> Link:
> https://lkml.kernel.org/r/20240624212008.663832-1-yazen.ghannam@amd.com
> 
> Yazen Ghannam (3):
>   x86/mce: Rename mce_setup() to mce_prep_record()
>   x86/mce: Define mce_prep_record() helpers for common and per-CPU
>     fields
>   x86/mce: Use mce_prep_record() helpers for
>     apei_smca_report_x86_error()
> 
>  arch/x86/include/asm/mce.h         |  2 +-
>  arch/x86/kernel/cpu/mce/amd.c      |  2 +-
>  arch/x86/kernel/cpu/mce/apei.c     | 18 +++++++-------
>  arch/x86/kernel/cpu/mce/core.c     | 38 ++++++++++++++++++++----------
>  arch/x86/kernel/cpu/mce/internal.h |  2 ++
>  5 files changed, 38 insertions(+), 24 deletions(-)
> 
> 
> base-commit: 1cd27e88888d54de5fefbeb0b44c26194ffa83ce

LGTM.

Reviewed-by: Avadhut Naik <avadhut.naik@....com>

-- 
Thanks,
Avadhut Naik