[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <D34WMEE9AIKU.1KLX21J35LNJA@iki.fi>
Date: Fri, 02 Aug 2024 00:48:15 +0300
From: "Jarkko Sakkinen" <jarkko.sakkinen@....fi>
To: "Stefan Berger" <stefanb@...ux.ibm.com>,
<linux-integrity@...r.kernel.org>, <linuxppc-dev@...ts.ozlabs.org>,
<jarkko@...nel.org>
Cc: <linux-kernel@...r.kernel.org>, <mpe@...erman.id.au>,
<naveen.n.rao@...ux.ibm.com>, <zohar@...ux.ibm.com>
Subject: Re: [PATCH v2] tpm: ibmvtpm: Call tpm2_sessions_init() to
initialize session support
On Mon Jul 29, 2024 at 4:29 PM EEST, Stefan Berger wrote:
> Commit d2add27cf2b8 ("tpm: Add NULL primary creation") introduced
> CONFIG_TCG_TPM2_HMAC. When this option is enabled on ppc64 then the
> following message appears in the kernel log due to a missing call to
> tpm2_sessions_init().
>
> [ 2.654549] tpm tpm0: auth session is not active
>
> Add the missing call to tpm2_session_init() to the ibmvtpm driver to
> resolve this issue.
>
> Fixes: d2add27cf2b8 ("tpm: Add NULL primary creation")
> Signed-off-by: Stefan Berger <stefanb@...ux.ibm.com>
> ---
> drivers/char/tpm/tpm_ibmvtpm.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
> index d3989b257f42..1e5b107d1f3b 100644
> --- a/drivers/char/tpm/tpm_ibmvtpm.c
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -698,6 +698,10 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
> rc = tpm2_get_cc_attrs_tbl(chip);
> if (rc)
> goto init_irq_cleanup;
> +
> + rc = tpm2_sessions_init(chip);
> + if (rc)
> + goto init_irq_cleanup;
> }
>
> return tpm_chip_register(chip);
Applied!
BR, Jarkko
Powered by blists - more mailing lists