linux-kernel - Re: [PATCH v24 10/34] ASoC: usb: Create SOC USB SND jack kcontrol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2141c04d-953b-47a5-a105-8a60ec370371@quicinc.com>
Date: Thu, 1 Aug 2024 15:43:16 -0700
From: Wesley Cheng <quic_wcheng@...cinc.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        <srinivas.kandagatla@...aro.org>, <mathias.nyman@...el.com>,
        <perex@...ex.cz>, <conor+dt@...nel.org>, <corbet@....net>,
        <broonie@...nel.org>, <lgirdwood@...il.com>, <krzk+dt@...nel.org>,
        <Thinh.Nguyen@...opsys.com>, <bgoswami@...cinc.com>, <tiwai@...e.com>,
        <gregkh@...uxfoundation.org>, <robh@...nel.org>
CC: <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-sound@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-doc@...r.kernel.org>,
        <alsa-devel@...a-project.org>
Subject: Re: [PATCH v24 10/34] ASoC: usb: Create SOC USB SND jack kcontrol

Hi Pierre,

On 8/1/2024 1:07 AM, Pierre-Louis Bossart wrote:
>
>
>> +static inline int snd_soc_usb_setup_offload_jack(struct snd_soc_component *component,
>> +						 struct snd_soc_jack *jack)
>> +{
>> +	return -ENODEV;
>> +}
>> +
>> +static inline int snd_soc_usb_disable_offload_jack(struct snd_soc_component *component)
>> +{
>> +	return -ENODEV;
>> +}
> usually fallback functions return 0, is the error code intentional?
ACK.
>
>> +int snd_soc_usb_setup_offload_jack(struct snd_soc_component *component,
>> +					struct snd_soc_jack *jack)
>> +{
>> +	int ret;
>> +
>> +	ret = snd_soc_card_jack_new(component->card, "USB Offload Playback Jack",
> do we need the reference to Playback?
No, will remove.
>> +					SND_JACK_HEADPHONE, jack);
> wondering if there would be any merit in defining a new type of jack,
> e.g. SND_JACK_USB since here the purpose is to notify that there's a USB
> device connected. The type of device does not really matter, does it?
>
Not as of now, but I think we discussed in the past that maybe depending on if playback and capture is supported, we can notify SND_JACK_HEADSET?  That is something I will need to change depending on how we want to handle the comments on patch#9

Thanks

Wesley Cheng

>> +	if (ret < 0) {
>> +		dev_err(component->card->dev, "Unable to add USB offload jack\n");
>> +		return ret;
>> +	}
>> +
>> +	ret = snd_soc_component_set_jack(component, jack, NULL);
>> +	if (ret) {
>> +		dev_err(component->card->dev, "Failed to set jack: %d\n", ret);
>> +		return ret;
>> +	}
>> +
>> +	return 0;