linux-kernel - RE: [PATCH] cpufreq/amd-pstate: Add the missing cpufreq_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <CYYPR12MB8655553BA7F283D787981B929CB22@CYYPR12MB8655.namprd12.prod.outlook.com>
Date: Thu, 1 Aug 2024 03:13:00 +0000
From: "Yuan, Perry" <Perry.Yuan@....com>
To: "Ugwekar, Dhananjay" <Dhananjay.Ugwekar@....com>, "Shenoy, Gautham Ranjal"
	<gautham.shenoy@....com>
CC: "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"rafael@...nel.org" <rafael@...nel.org>, "viresh.kumar@...aro.org"
	<viresh.kumar@...aro.org>, "Huang, Ray" <Ray.Huang@....com>, "Limonciello,
 Mario" <Mario.Limonciello@....com>
Subject: RE: [PATCH] cpufreq/amd-pstate: Add the missing cpufreq_cpu_put()

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Dhananjay

> -----Original Message-----
> From: Ugwekar, Dhananjay <Dhananjay.Ugwekar@....com>
> Sent: Wednesday, July 31, 2024 4:39 PM
> To: Huang, Ray <Ray.Huang@....com>; Shenoy, Gautham Ranjal
> <gautham.shenoy@....com>; Limonciello, Mario
> <Mario.Limonciello@....com>; Yuan, Perry <Perry.Yuan@....com>;
> rafael@...nel.org; viresh.kumar@...aro.org
> Cc: linux-pm@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] cpufreq/amd-pstate: Add the missing cpufreq_cpu_put()
>
> Forgot the fixes tag,
>
> On 7/31/2024 2:02 PM, Dhananjay Ugwekar wrote:
> > Fix the reference counting of cpufreq_policy object in
> > amd_pstate_update() function by adding the missing cpufreq_cpu_put().
> >
>
> Fixes: e8f555daacd3 ("cpufreq/amd-pstate: fix setting policy current
> frequency value")
>
> Thanks,
> Dhananjay
> > Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@....com>
> > ---
> >  drivers/cpufreq/amd-pstate.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/cpufreq/amd-pstate.c
> > b/drivers/cpufreq/amd-pstate.c index 804fab4ebb26..36edae40db1a
> 100644
> > --- a/drivers/cpufreq/amd-pstate.c
> > +++ b/drivers/cpufreq/amd-pstate.c
> > @@ -560,6 +560,8 @@ static void amd_pstate_update(struct amd_cpudata
> > *cpudata, u32 min_perf,
> >
> >     amd_pstate_update_perf(cpudata, min_perf, des_perf,
> >                            max_perf, fast_switch);
> > +
> > +   cpufreq_cpu_put(policy);
> >  }
> >
> >  static int amd_pstate_verify(struct cpufreq_policy_data *policy)

Thanks for the fix,   it needs to send v2 with the Fixes tag.

Reviewed-by: Perry Yuan <perry.yuan@....com>

Best Regards.

Perry.