[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAGXv+5EYMgeNnQ3BU8cxy0a5aH8e+GbO=-OFVysU2MqBy+yQFQ@mail.gmail.com>
Date: Thu, 1 Aug 2024 12:01:30 +0800
From: Chen-Yu Tsai <wenst@...omium.org>
To: "yr.yang" <yr.yang@...iatek.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, linux-sound@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org,
Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH 1/1] ASoC: mediatek: mt8188: add register to volatile_register
Hi,
On Thu, Aug 1, 2024 at 11:11 AM yr.yang <yr.yang@...iatek.com> wrote:
>
> From: YR Yang <yr.yang@...iatek.com>
>
> Add AFE Control Register 0 to volatile_register.
> AFE_DAC_CON0 can be modified by both SOF and ALSA driver.
> If this register read & write by cache mode,
> the cached value may be not the real value
> when the register modified by other side.
> It will cause playback or capture fail.
> Need add AFE_DAC_CON0 to volatile register.
You should mention this specific register in the patch subject.
Something like:
ASoC: mediatek: mt8188: Mark AFE_DAC_CON0 register as volatile
ChenYu
> Signed-off-by: YR Yang <yr.yang@...iatek.com>
>
> ---
> sound/soc/mediatek/mt8188/mt8188-afe-pcm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/mediatek/mt8188/mt8188-afe-pcm.c b/sound/soc/mediatek/mt8188/mt8188-afe-pcm.c
> index ccb6c1f3adc7..73e5c63aeec8 100644
> --- a/sound/soc/mediatek/mt8188/mt8188-afe-pcm.c
> +++ b/sound/soc/mediatek/mt8188/mt8188-afe-pcm.c
> @@ -2748,6 +2748,7 @@ static bool mt8188_is_volatile_reg(struct device *dev, unsigned int reg)
> case AFE_ASRC12_NEW_CON9:
> case AFE_LRCK_CNT:
> case AFE_DAC_MON0:
> + case AFE_DAC_CON0:
> case AFE_DL2_CUR:
> case AFE_DL3_CUR:
> case AFE_DL6_CUR:
> --
> 2.34.1
>
>
Powered by blists - more mailing lists