[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <fd2dc636-762f-4fd4-acd0-a473097406ff@gmail.com>
Date: Thu, 1 Aug 2024 07:24:14 +0200
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Manjae Cho <manjae.cho@...sung.com>, gregkh@...uxfoundation.org
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] staging: rtl8723bs: Improve clarity of MAR usage
On 8/1/24 00:51, Manjae Cho wrote:
> This patch improves the readability of the code related to the Multicast
> Address Register (REG_MAR) in the rtl8723bs driver. It adds comments to
> clarify the purpose and offset of the register, making the code more
> self-documenting without introducing new macros.
>
> Signed-off-by: Manjae Cho <manjae.cho@...sung.com>
> ---
>
> v5:
> - Maintain consistent patch versioning
> - Add change history
>
> v4:
> - Refine commit message
> - Adjust comment wording
>
> v3:
> - Remove MAR0 and MAR4 definitions
> - Add comments for clarity instead of new macros
> - Maintain existing REG_MAR usage
>
> v2:
> - Update patch title
> - Improve commit message
>
> v1:
> - Initial version: Introduce MAR0 and MAR4 definitions
>
> drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> index c9cd6578f7f8..535cd439121d 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> @@ -380,8 +380,8 @@ static void _InitWMACSetting(struct adapter *padapter)
> rtw_write32(padapter, REG_RCR, pHalData->ReceiveConfig);
>
> /* Accept all multicast address */
> - rtw_write32(padapter, REG_MAR, 0xFFFFFFFF);
> - rtw_write32(padapter, REG_MAR + 4, 0xFFFFFFFF);
> + rtw_write32(padapter, REG_MAR, 0xFFFFFFFF); /* Offset 0x0620-0x0623 */
> + rtw_write32(padapter, REG_MAR + 4, 0xFFFFFFFF); /* Offset 0x0624-0x0627 */
>
> /* Accept all data frames */
> value16 = 0xFFFF;
Reviewed-by: Philipp Hortmann <philipp.g.hortmann@...il.com>
Powered by blists - more mailing lists