linux-kernel - Re: [PATCH v3] exfat: check disk status during buffer write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd8y7-XzBeGLRKgEabcZEabmfn2ZTHXgb9jPXwTN5fb3NA@mail.gmail.com>
Date: Thu, 1 Aug 2024 14:54:30 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: 崔东亮 (Dongliang Cui) <Dongliang.Cui@...soc.com>
Cc: Christoph Hellwig <hch@...radead.org>, "sj1557.seo@...sung.com" <sj1557.seo@...sung.com>, 
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"niuzhiguo84@...il.com" <niuzhiguo84@...il.com>, 王皓 (Hao_hao Wang) <Hao_hao.Wang@...soc.com>, 
	王科 (Ke Wang) <Ke.Wang@...soc.com>, 
	牛志国 (Zhiguo Niu) <Zhiguo.Niu@...soc.com>, 
	"cuidongliang390@...il.com" <cuidongliang390@...il.com>
Subject: Re: [PATCH v3] exfat: check disk status during buffer write

2024년 8월 1일 (목) 오후 2:30, 崔东亮 (Dongliang Cui) <Dongliang.Cui@...soc.com>님이 작성:
>
> Besides the additional checks for the shutdown flag already mentioned the subject is now incorrect I think, it should talk about implementing shutdown handling.
>
> In case you haven't done so yet, please also see if exfat now passes the various testcases in xfstests that exercise the shutdown path.
>
> Otherwise this looks reasonable to me, thanks for the work!
>
> Hi Christoph,
>
> Thank you for your suggestion. I think the current patch is primarily aimed at addressing the issue of hotplug and ensuring writers are notified when a device has been ejected.
>
> Previously, exfat didn't have a shutdown process inherently, and hotplug didn't pose any significant issues, except for the one we're discussing in this email.
>
> Therefore, regarding what specific actions should be taken during shutdown, I would appreciate your input or any suggestions from Sungjong and Namjae.
>
> Additionally, can the shutdown handling be supplemented with another patch if there is indeed a need to implement some exfat shutdown processes?
>
> HI Sungjong and Namjae.
>
> Based on the above, what do you think, or do you have any suggestions?
There is no reason to split it into two and I would prefer to apply it
as one patch.
I would appreciate it if you could send the list an updated v4 patch
including what Christoph and I pointed out.