linux-kernel - Re: [PATCH 2/2] mm: tlb: add tlb swap entries batch async release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4379c4cb-3b09-4ad7-8859-54949f778c78@vivo.com>
Date: Thu, 1 Aug 2024 14:54:32 +0800
From: zhiguojiang <justinjiang@...o.com>
To: kernel test robot <lkp@...el.com>,
 Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org,
 Will Deacon <will@...nel.org>, "Aneesh Kumar K.V" <aneesh.kumar@...nel.org>,
 Nick Piggin <npiggin@...nel.dk>, Peter Zijlstra <peterz@...radead.org>,
 Arnd Bergmann <arnd@...db.de>, Johannes Weiner <hannes@...xchg.org>,
 Michal Hocko <mhocko@...nel.org>, Roman Gushchin <roman.gushchin@...ux.dev>,
 Shakeel Butt <shakeel.butt@...ux.dev>, Muchun Song <muchun.song@...ux.dev>,
 linux-arch@...r.kernel.org, cgroups@...r.kernel.org,
 Barry Song <21cnbao@...il.com>
Cc: oe-kbuild-all@...ts.linux.dev,
 Linux Memory Management List <linux-mm@...ck.org>, opensource.kernel@...o.com
Subject: Re: [PATCH 2/2] mm: tlb: add tlb swap entries batch async release



在 2024/8/1 2:19, kernel test robot 写道:
> Hi Zhiguo,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on akpm-mm/mm-everything]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Zhiguo-Jiang/mm-move-task_is_dying-to-h-headfile/20240730-215136
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
> patch link:    https://lore.kernel.org/r/20240730114426.511-3-justinjiang%40vivo.com
> patch subject: [PATCH 2/2] mm: tlb: add tlb swap entries batch async release
> config: i386-randconfig-061-20240731 (https://download.01.org/0day-ci/archive/20240801/202408010150.13yZScv6-lkp@intel.com/config)
> compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240801/202408010150.13yZScv6-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202408010150.13yZScv6-lkp@intel.com/
>
> sparse warnings: (new ones prefixed by >>)
Hi,

I have fix this compilation warning issue in the bellow patch. Please
kindly help to test with this patch.
https://lore.kernel.org/linux-mm/20240801065035.621-1-justinjiang@vivo.com/T/#u

Thanks
Zhiguo
>>> mm/mmu_gather.c:54:10: sparse: sparse: symbol 'nr_exiting_processes' was not declared. Should it be static?
>     mm/mmu_gather.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h):
>     include/linux/page-flags.h:235:46: sparse: sparse: self-comparison always evaluates to false
>     include/linux/page-flags.h:235:46: sparse: sparse: self-comparison always evaluates to false
>
> vim +/nr_exiting_processes +54 mm/mmu_gather.c
>
>      53	
>    > 54	atomic_t nr_exiting_processes = ATOMIC_INIT(0);
>      55	static struct kmem_cache *swap_gather_cachep;
>      56	static struct workqueue_struct *swapfree_wq;
>      57	static DEFINE_STATIC_KEY_TRUE(tlb_swap_asyncfree_disabled);
>      58	
>