linux-kernel - Re: [PATCH v2 0/2] fsconfig: minor fsparam

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240801-manchmal-produkt-16d3e590cfb1@brauner>
Date: Thu,  1 Aug 2024 09:04:54 +0200
From: Christian Brauner <brauner@...nel.org>
To: Aleksa Sarai <cyphar@...har.com>
Cc: Christian Brauner <brauner@...nel.org>,
	autofs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	codalist@...a.cs.cmu.edu,
	Ian Kent <raven@...maw.net>,
	Bill O'Donnell <bodonnel@...hat.com>,
	Jan Harkes <jaharkes@...cmu.edu>,
	coda@...cmu.edu,
	Eric Sandeen <sandeen@...hat.com>,
	David Howells <dhowells@...hat.com>
Subject: Re: [PATCH v2 0/2] fsconfig: minor fsparam_fd fixes

On Wed, 31 Jul 2024 23:10:26 +1000, Aleksa Sarai wrote:
> While working on adding an fsparam_fd() argument to cgroupfs, I noticed
> that there are only two users of fsparam_fd() and they both seemed to
> have minor issues:
> 
> * autofs has a missing fput() when using FSCONFIG_SET_FD.
> * coda uses fsparam_fd() but it ignores param->file and so ends up
>   re-getting the file. This doesn't change the behaviour but it seems
>   preferable to have all users of fsparam_fd() have the same logic.
> 
> [...]

Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc

[1/2] autofs: fix missing fput for FSCONFIG_SET_FD
      https://git.kernel.org/vfs/vfs/c/9f6b314ecc8b
[2/2] coda: use param->file for FSCONFIG_SET_FD
      https://git.kernel.org/vfs/vfs/c/b0839e9bbc5b