linux-kernel - Re: [PATCH 6/8] usb: misc: eud: Add High-Speed Phy control for EUD operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e7a95d94-6ca3-4700-a544-5f37c5e58f6b@kernel.org>
Date: Thu, 1 Aug 2024 09:45:31 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Elson Serrao <quic_eserrao@...cinc.com>, andersson@...nel.org,
 konrad.dybcio@...aro.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, gregkh@...uxfoundation.org
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 6/8] usb: misc: eud: Add High-Speed Phy control for EUD
 operations

On 01/08/2024 00:38, Elson Serrao wrote:
> 
> 
> On 7/30/2024 10:39 PM, Krzysztof Kozlowski wrote:
>> On 31/07/2024 00:24, Elson Roy Serrao wrote:
>>> The Embedded USB Debugger(EUD) is a HS-USB on-chip hub to support the
>>> debug and trace capabilities on Qualcomm devices. It is physically
>>> present in between the usb connector and the usb controller. Being a
>>> HS USB hub, it relies on HS Phy for its functionality. Add HS phy
>>> support in the eud driver and control the phy during eud enable/disable
>>> operations.
>>>
>>
>> ...
>>>  static ssize_t enable_show(struct device *dev,
>>> @@ -186,6 +216,11 @@ static int eud_probe(struct platform_device *pdev)
>>>  
>>>  	chip->dev = &pdev->dev;
>>>  
>>> +	chip->usb2_phy = devm_phy_get(chip->dev, "usb2-phy");
>>> +	if (IS_ERR(chip->usb2_phy))
>>> +		return dev_err_probe(chip->dev, PTR_ERR(chip->usb2_phy),
>>> +				     "no usb2 phy configured\n");
>>
>> This nicely breaks all users.
>>
>> NAK
>>
> 
> As per my comment in [patch 1/8], phy would be a required property and hence I will first modify
> and enable EUD on the existing user (sc7280 SoC) and then extend this to other users.

NAK, you break existing users without clear reason.

Best regards,
Krzysztof