linux-kernel - Re: [PATCH 0/4] ad7124 fixes and improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e6e2f4163faa217e87a5c44a7c35cfba5870844.camel@gmail.com>
Date: Thu, 01 Aug 2024 10:36:16 +0200
From: Nuno Sá <noname.nuno@...il.com>
To: Dumitru Ceclan <mitrutzceclan@...il.com>, Jonathan Cameron
 <jic23@...nel.org>, Stefan Popa <stefan.popa@...log.com>, Alexandru Tachici
 <alexandru.tachici@...log.com>
Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 linux-iio@...r.kernel.org,  linux-kernel@...r.kernel.org, Dumitru Ceclan
 <dumitru.ceclan@...log.com>
Subject: Re: [PATCH 0/4] ad7124 fixes and improvements

On Wed, 2024-07-31 at 15:37 +0300, Dumitru Ceclan wrote:
> This patch series adds fixes and improvements in the ad7124 driver.
> 
> Fixes:
> - properly compare config values
> - add a delay after reset to allow chip initialization
> 
> Improvements:
> - reduce the number of SPI transfers
> - ensure that after probe the ADC is in idle mode
>   and not continuos conversion mode
> 
> Another thing that could be considered is improving the config pop
> behavior as kfifo_get() will return the least recently added config
> instead of the least recently *used* one.
> 
> This could be an issue when multiple channels are using the same "old"
> config and the LRU considers that one as the least recently used.
> 
> If this is considered a valid issue, I can add another patch for it.
> 
> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@...log.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@...log.com>

> Dumitru Ceclan (4):
>       iio: adc: ad7124: fix chip ID mismatch
>       iio: adc: ad7124: fix config comparison
>       iio: adc: ad7124: reduce the number of SPI transfers
>       iio: adc: ad7124: set initial ADC mode to idle
> 
>  drivers/iio/adc/ad7124.c | 61 ++++++++++++++++++++++++-----------------------
> -
>  1 file changed, 31 insertions(+), 30 deletions(-)
> ---
> base-commit: 380afccc2a55e8015adae4266e8beff96ab620be
> change-id: 20240731-ad7124-fix-37aec7fe0b6b
> 
> Best regards,