linux-kernel - Re: [PATCH] dt-bindings: arm: socfpga: Add Altera SOCFPGA SDRAM EDAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0582fd8a-216a-4569-a1ad-e4aafc926bf1@kernel.org>
Date: Thu, 1 Aug 2024 10:46:14 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alessandro Zanni <alessandro.zanni87@...il.com>, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, skhan@...uxfoundation.org
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: arm: socfpga: Add Altera SOCFPGA SDRAM EDAS

On 01/08/2024 10:44, Krzysztof Kozlowski wrote:
> On 01/08/2024 01:02, Alessandro Zanni wrote:
> 
> Thank you for your patch. There is something to discuss/improve.
> 
> 
>> diff --git a/Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml b/Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml
>> new file mode 100644
>> index 000000000000..78fbe31e4a2b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml
> 
> Filename like compatible, so altr,sdram-edac.yaml
> 
> Fix the placement - arm is only for top-level sutff. This goes to
> memory-controllers or edac
> 

So this was a v2? Then version your patches correctly and add
appropriate and detailed changelog under ---.

See submitting patches.

Best regards,
Krzysztof