linux-kernel - Re: [PATCH 2/2] drm/bridge: synopsys: Add DW HDMI QP TX Controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19af747f-0911-4896-afba-b63c585554d4@kernel.org>
Date: Thu, 1 Aug 2024 10:50:02 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>,
 Andrzej Hajda <andrzej.hajda@...el.com>,
 Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: kernel@...labora.com, dri-devel@...ts.freedesktop.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Heiko Stübner <heiko@...ech.de>,
 Andy Yan <andy.yan@...k-chips.com>, Alexandre ARNOUD <aarnoud@...com>,
 Luis de Arquer <ldearquer@...il.com>, Algea Cao <algea.cao@...k-chips.com>
Subject: Re: [PATCH 2/2] drm/bridge: synopsys: Add DW HDMI QP TX Controller
 driver

On 01/08/2024 04:05, Cristian Ciocaltea wrote:
> The Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX Controller supports
> the following features, among others:

...

> +
> +void dw_hdmi_qp_unbind(struct dw_hdmi_qp *hdmi)
> +{
> +}
> +EXPORT_SYMBOL_GPL(dw_hdmi_qp_unbind);

This looks like quite useless export. Drop.


> +
> +void dw_hdmi_qp_resume(struct device *dev, struct dw_hdmi_qp *hdmi)
> +{
> +	dw_hdmi_qp_init_hw(hdmi);
> +}
> +EXPORT_SYMBOL_GPL(dw_hdmi_qp_resume);
> +
> +MODULE_AUTHOR("Algea Cao <algea.cao@...k-chips.com>");
> +MODULE_AUTHOR("Cristian Ciocaltea <cristian.ciocaltea@...labora.com>");
> +MODULE_DESCRIPTION("DW HDMI QP transmitter driver");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:dw-hdmi-qp");

That's not a platform driver. That does not look like driver at all,
just some helper code without any user

1. Drop alias.
2. Provide users for this code. You cannot add some helper functions
which nothing uses.
3. Fix subject, commit msg, module description - there is no driver
here, but helper functions. Otherwise how does it bind?

Best regards,
Krzysztof