linux-kernel - Re: [PATCH v12 03/84] KVM: Drop KVM_ERR_PTR_BAD_PAGE and instead return NULL to indicate an error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875xskfwnd.fsf@draig.linaro.org>
Date: Thu, 01 Aug 2024 09:57:26 +0100
From: Alex Bennée <alex.bennee@...aro.org>
To: Sean Christopherson <seanjc@...gle.com>
Cc: Paolo Bonzini <pbonzini@...hat.com>,  Marc Zyngier <maz@...nel.org>,
  Oliver Upton <oliver.upton@...ux.dev>,  Tianrui Zhao
 <zhaotianrui@...ngson.cn>,  Bibo Mao <maobibo@...ngson.cn>,  Huacai Chen
 <chenhuacai@...nel.org>,  Michael Ellerman <mpe@...erman.id.au>,  Anup
 Patel <anup@...infault.org>,  Paul Walmsley <paul.walmsley@...ive.com>,
  Palmer Dabbelt <palmer@...belt.com>,  Albert Ou <aou@...s.berkeley.edu>,
  Christian Borntraeger <borntraeger@...ux.ibm.com>,  Janosch Frank
 <frankja@...ux.ibm.com>,  Claudio Imbrenda <imbrenda@...ux.ibm.com>,
  kvm@...r.kernel.org,  linux-arm-kernel@...ts.infradead.org,
  kvmarm@...ts.linux.dev,  loongarch@...ts.linux.dev,
  linux-mips@...r.kernel.org,  linuxppc-dev@...ts.ozlabs.org,
  kvm-riscv@...ts.infradead.org,  linux-riscv@...ts.infradead.org,
  linux-kernel@...r.kernel.org,  David Matlack <dmatlack@...gle.com>,
  David Stevens <stevensd@...omium.org>
Subject: Re: [PATCH v12 03/84] KVM: Drop KVM_ERR_PTR_BAD_PAGE and instead
 return NULL to indicate an error

Sean Christopherson <seanjc@...gle.com> writes:

> Remove KVM_ERR_PTR_BAD_PAGE and instead return NULL, as "bad page" is just
> a leftover bit of weirdness from days of old when KVM stuffed a "bad" page
> into the guest instead of actually handling missing pages.  See commit
> cea7bb21280e ("KVM: MMU: Make gfn_to_page() always safe").
>
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>

Reviewed-by: Alex Bennée <alex.bennee@...aro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro