linux-kernel - [PATCH] backlight: pwm_bl: print errno for probe errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240801091255.1410027-1-martin.kepplinger-novakovic@ginzinger.com>
Date: Thu, 1 Aug 2024 11:12:55 +0200
From: Martin Kepplinger-Novaković
	<martin.kepplinger-novakovic@...zinger.com>
To: ukleinek@...nel.org,
	lee@...nel.org,
	daniel.thompson@...aro.org,
	jingoohan1@...il.com
CC: linux-pwm@...r.kernel.org,
	dri-devel@...ts.freedesktop.org,
	linux-fbdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] backlight: pwm_bl: print errno for probe errors

This makes debugging often easier.

Signed-off-by: Martin Kepplinger-Novaković <martin.kepplinger-novakovic@...zinger.com>
---
 drivers/video/backlight/pwm_bl.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index f1005bd0c41e3..cc7e7af71891f 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -502,7 +502,8 @@ static int pwm_backlight_probe(struct platform_device *pdev)
 						  GPIOD_ASIS);
 	if (IS_ERR(pb->enable_gpio)) {
 		ret = dev_err_probe(&pdev->dev, PTR_ERR(pb->enable_gpio),
-				    "failed to acquire enable GPIO\n");
+				    "failed to acquire enable GPIO: %ld\n",
+				    PTR_ERR(pb->enable_gpio));
 		goto err_alloc;
 	}
 
@@ -513,7 +514,8 @@ static int pwm_backlight_probe(struct platform_device *pdev)
 			pb->power_supply = NULL;
 		} else {
 			dev_err_probe(&pdev->dev, ret,
-				      "failed to acquire power regulator\n");
+				      "failed to acquire power regulator: %d\n",
+				      ret);
 			goto err_alloc;
 		}
 	}
@@ -521,7 +523,8 @@ static int pwm_backlight_probe(struct platform_device *pdev)
 	pb->pwm = devm_pwm_get(&pdev->dev, NULL);
 	if (IS_ERR(pb->pwm)) {
 		ret = dev_err_probe(&pdev->dev, PTR_ERR(pb->pwm),
-				    "unable to request PWM\n");
+				    "unable to request PWM: %ld\n",
+				    PTR_ERR(pb->pwm));
 		goto err_alloc;
 	}
 
-- 
2.39.2

Download attachment "smime.p7s" of type "application/pkcs7-signature" (7522 bytes)