linux-kernel - Re: [PATCH] tg3: Add param `short_preamble` to enable MDIO traffic to external PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLikjqVZUXtWY5YBJPT56OqW0z00DxkaENzG74M64Rrr81w@mail.gmail.com>
Date: Fri, 2 Aug 2024 12:51:15 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Paul Menzel <pmenzel@...gen.mpg.de>
Cc: Pavan Chebbi <pavan.chebbi@...adcom.com>, Michael Chan <mchan@...adcom.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Roy Lee <roy_lee@...ton.com>, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tg3: Add param `short_preamble` to enable MDIO traffic to
 external PHYs

On Fri, Aug 2, 2024 at 3:05 AM Paul Menzel <pmenzel@...gen.mpg.de> wrote:

> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index 0ec5f01551f9..9b4ab201fd9a 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -233,6 +233,10 @@ static int tg3_debug = -1; /* -1 == use TG3_DEF_MSG_ENABLE as value */
>  module_param(tg3_debug, int, 0);
>  MODULE_PARM_DESC(tg3_debug, "Tigon3 bitmapped debugging message enable value");
>
> +static int short_preamble = 0;
> +module_param(short_preamble, int, 0);
> +MODULE_PARM_DESC(short_preamble, "Enable short preamble.");
> +

Module parameters are generally not accepted.  If this is something
other devices can potentially use, it's better to use a more common
interface.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)