linux-kernel - Re: [PATCH net 5/6] net: dsa: vsc73xx: allow phy resetting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f8fe924-03fd-41be-8e01-1580b650ec40@gmail.com>
Date: Fri, 2 Aug 2024 14:55:59 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Pawel Dembicki <paweldembicki@...il.com>, netdev@...r.kernel.org
Cc: Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, Linus Walleij <linus.walleij@...aro.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 5/6] net: dsa: vsc73xx: allow phy resetting

On 8/2/24 01:04, Pawel Dembicki wrote:
> Now, phy reset isn't a problem for vsc73xx switches.
> 'soft_reset' can be done normally.
> 
> This commit removes the reset blockade in the 'vsc73xx_phy_write'
> function.
> 
> Signed-off-by: Pawel Dembicki <paweldembicki@...il.com>

Same comment as Linus and Russell, with a better explanation:

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian