linux-kernel - Re: [PATCH 1/2] dt-bindings: display: bridge: Add schema for Synopsys DW HDMI QP TX IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a0f0b7a9-db81-4f64-83f0-8e1f93f0be55@kernel.org>
Date: Fri, 2 Aug 2024 08:46:16 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>,
 Andrzej Hajda <andrzej.hajda@...el.com>,
 Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: kernel@...labora.com, dri-devel@...ts.freedesktop.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Heiko Stübner <heiko@...ech.de>,
 Andy Yan <andy.yan@...k-chips.com>, Alexandre ARNOUD <aarnoud@...com>,
 Luis de Arquer <ldearquer@...il.com>
Subject: Re: [PATCH 1/2] dt-bindings: display: bridge: Add schema for Synopsys
 DW HDMI QP TX IP

On 01/08/2024 11:29, Cristian Ciocaltea wrote:
>>> +  interrupts:
>>> +    minItems: 4
>>> +    maxItems: 5
>>> +    items:
>>> +      - description: AVP Unit interrupt
>>> +      - description: CEC interrupt
>>> +      - description: eARC RX interrupt
>>> +      - description: Main Unit interrupt
>>> +    additionalItems: true
>>> +
>>> +  interrupt-names:
>>> +    minItems: 4
>>> +    maxItems: 5
>>> +    items:
>>> +      - const: avp
>>> +      - const: cec
>>> +      - const: earc
>>> +      - const: main
>>> +    additionalItems: true
>>
>> Sorry, there is no user of this and nothing here is actually common
>> except first entries in clocks and interrupts properties.
>>
>> I don't see any benefit of this.
> 
> Sorry, I should have better indicated this is part of a larger changeset -
> the cover mentions this is a reworked version of an initial (larger) series
> and the split has been explicitly suggested during the review.

This split is really odd. It creates unnecessary dependency, blocks
automated testing and confuses reviewers because reviewers expect common
code followed by its user.

Best regards,
Krzysztof