linux-kernel - Re: [LTP] [PATCH v4 0/5] Add fchmodat2 testing suite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240802071959.GA1593427@pevik>
Date: Fri, 2 Aug 2024 09:19:59 +0200
From: Petr Vorel <pvorel@...e.cz>
To: Aleksa Sarai <cyphar@...har.com>,
	Andrea Cervesato <andrea.cervesato@...e.de>, ltp@...ts.linux.it,
	Alexey Gladkov <legion@...nel.org>,
	Christian Brauner <brauner@...nel.org>,
	Cyril Hrubis <chrubis@...e.cz>,
	Adhemerval Zanella <adhemerval.zanella@...aro.org>,
	Gaël PORTAY <gael.portay@...ne.fr>,
	linux-kernel@...r.kernel.org
Subject: Re: [LTP] [PATCH v4 0/5] Add fchmodat2 testing suite

Hi all,

...
> @Andrea, I guess we want something like this:

> +++ testcases/kernel/syscalls/fchmodat2/fchmodat2_01.c
> @@ -43,9 +43,10 @@ static void test_symbolic_link(void)
>  	verify_mode(fd_dir, FNAME, S_IFREG | 0700);
>  	verify_mode(fd_dir, SNAME, S_IFLNK | 0777);

> -	TST_EXP_PASS(fchmodat2(fd_dir, SNAME, 0640, AT_SYMLINK_NOFOLLOW));
> -	verify_mode(fd_dir, FNAME, S_IFREG | 0700);
> -	verify_mode(fd_dir, SNAME, S_IFLNK | 0640);
> +	if (tst_kvercmp(6, 6, 0) >= 0) {
> +		TST_EXP_FAIL(tst_syscall(__NR_fchmodat2, fd_dir, SNAME, 0640,
> +					 AT_SYMLINK_NOFOLLOW), EOPNOTSUPP);
> +	}
>  }

Actually, this has been backported to all stable/LTS trees (up to 4.19).
Thus there should not be a version check, but instead suggesting a missing
5d1f903f75a8 commit.

	.tags = (const struct tst_tag[]) {
		{"linux-git", "5d1f903f75a8"},
		{}
	}

Kind regards,
Petr