linux-kernel - Re: [PATCH v2] drm: Add documentation for struct drm_pane_size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <875xsj73he.fsf@intel.com>
Date: Fri, 02 Aug 2024 11:06:53 +0300
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: abid-sayyad <sayyad.abid16@...il.com>, airlied@...il.com
Cc: daniel@...ll.ch, maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
 tzimmermann@...e.de, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, abid-sayyad <sayyad.abid16@...il.com>
Subject: Re: [PATCH v2] drm: Add documentation for struct drm_pane_size_hint

On Thu, 01 Aug 2024, abid-sayyad <sayyad.abid16@...il.com> wrote:
> Fixed warning for the following:
> ./include/uapi/drm/drm_mode.h:869: warning: Function parameter or struct member
> 				'width' not described in 'drm_plane_size_hint'
> ./include/uapi/drm/drm_mode.h:869: warning: Function parameter or struct member
> 				'height' not described in 'drm_plane_size_hint'
>
> Signed-off-by: abid-sayyad <sayyad.abid16@...il.com>
> ---
> My sincere apologies for the spam and the patch subject error

Usually there's no need to resend, at least not immediately, because of
issues in the subject or the commit message. Many of them can be fixed
while applying, and if not, you'll be asked to fix and resend.

Reviewed-by: Jani Nikula <jani.nikula@...el.com>


> Changes in v2:
> - Adress review feedback regarding indentation in the fix
> - Link to v1
> https://lore.kernel.org/all/20240801102239.572718-1-sayyad.abid16@gmail.com/
>
>  include/uapi/drm/drm_mode.h | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
> index d390011b89b4..9d398335d871 100644
> --- a/include/uapi/drm/drm_mode.h
> +++ b/include/uapi/drm/drm_mode.h
> @@ -864,7 +864,13 @@ struct drm_color_lut {
>   * array of struct drm_plane_size_hint.
>   */
>  struct drm_plane_size_hint {
> +	/**
> +	 * @width: width of the plane in pixels.
> +	 */
>  	__u16 width;
> +	/**
> +	 * @height: height of the plane in pixels.
> +	 */
>  	__u16 height;
>  };
>
> --
> 2.39.2
>

-- 
Jani Nikula, Intel