linux-kernel - Re: [PATCH] riscv: support KASAN instrumentation of bitops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240802-showpiece-uneaten-7920dbf75aa8@spud>
Date: Fri, 2 Aug 2024 09:10:29 +0100
From: Conor Dooley <conor@...nel.org>
To: Alexandre Ghiti <alex@...ti.fr>
Cc: Qingfang Deng <dqfext@...il.com>, Yury Norov <yury.norov@...il.com>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>,
	"open list:RISC-V ARCHITECTURE" <linux-riscv@...ts.infradead.org>,
	open list <linux-kernel@...r.kernel.org>,
	Qingfang Deng <qingfang.deng@...lower.com.cn>
Subject: Re: [PATCH] riscv: support KASAN instrumentation of bitops

On Fri, Aug 02, 2024 at 07:45:38AM +0200, Alexandre Ghiti wrote:
> Hi Qingfang,
> 
> On 02/08/2024 06:05, Qingfang Deng wrote:
> > From: Qingfang Deng <qingfang.deng@...lower.com.cn>
> > 
> > The arch-specific bitops are not being picked up by the KASAN test
> > suite.
> > 
> > Instrumentation is done via the bitops/instrumented-{atomic,lock}.h
> > headers. They require that arch-specific versions of bitop functions
> > are renamed to arch_*. Do this renaming.
> > 
> > As most comments are identical to the ones in the instrumented headers,
> > remove them.
> > 
> > Signed-off-by: Qingfang Deng <qingfang.deng@...lower.com.cn>

> Samuel has just posted a similar patch here https://lore.kernel.org/linux-riscv/20240801033725.28816-1-samuel.holland@sifive.com/T/#t

Additionally Samuel's patch has the advantage of compiling :)

This one errors with:
include/asm-generic/bitops/instrumented-lock.h:80:16: error: implicit declaration of function 'arch_xor_unlock_is_negative_byte'; did you mean 'xor_unlock_is_negative_byte'? [-Werror=implicit-function-declaration]

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)