[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZqyXfonFv1GNlbvK@shell.armlinux.org.uk>
Date: Fri, 2 Aug 2024 09:23:26 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: jitendra.vegiraju@...adcom.com
Cc: netdev@...r.kernel.org, alexandre.torgue@...s.st.com,
joabreu@...opsys.com, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com, mcoquelin.stm32@...il.com,
bcm-kernel-feedback-list@...adcom.com, richardcochran@...il.com,
ast@...nel.org, daniel@...earbox.net, hawk@...nel.org,
john.fastabend@...il.com, linux-kernel@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, bpf@...r.kernel.org,
andrew@...n.ch, horms@...nel.org, florian.fainelli@...adcom.com
Subject: Re: [PATCH net-next v3 2/3] net: stmmac: Integrate dwxgmac4 into
stmmac hwif handling
On Thu, Aug 01, 2024 at 08:18:21PM -0700, jitendra.vegiraju@...adcom.com wrote:
> +static u32 stmmac_get_user_version(struct stmmac_priv *priv, u32 id_reg)
> +{
> + u32 reg = readl(priv->ioaddr + id_reg);
> +
> + if (!reg) {
> + dev_info(priv->device, "User Version not available\n");
> + return 0x0;
> + }
> +
> + return (reg & GENMASK(23, 16)) >> 16;
return FIELD_GET(GENMASK(23, 16), reg);
For even more bonus points, use a #define for the field mask.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists