[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240802083332.2471281-1-jacky_chou@aspeedtech.com>
Date: Fri, 2 Aug 2024 16:33:32 +0800
From: Jacky Chou <jacky_chou@...eedtech.com>
To: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
<pabeni@...hat.com>, <jacky_chou@...eedtech.com>,
<u.kleine-koenig@...gutronix.de>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: [PATCH] net: ftgmac100: Get link speed and duplex for NC-SI
The ethtool of this driver uses the phy API of ethtool
to get the link information from PHY driver.
Because the NC-SI is forced on 100Mbps and full duplex,
the driver connects a fixed-link phy driver for NC-SI.
The ethtool will get the link information from the
fixed-link phy driver.
Signed-off-by: Jacky Chou <jacky_chou@...eedtech.com>
---
drivers/net/ethernet/faraday/ftgmac100.c | 37 ++++++++++++++----------
1 file changed, 21 insertions(+), 16 deletions(-)
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
index fddfd1dd5070..0c820997ef88 100644
--- a/drivers/net/ethernet/faraday/ftgmac100.c
+++ b/drivers/net/ethernet/faraday/ftgmac100.c
@@ -26,6 +26,7 @@
#include <linux/of_net.h>
#include <net/ip.h>
#include <net/ncsi.h>
+#include <linux/phy_fixed.h>
#include "ftgmac100.h"
@@ -50,6 +51,15 @@
#define FTGMAC_100MHZ 100000000
#define FTGMAC_25MHZ 25000000
+/* For NC-SI to register a fixed-link phy device */
+struct fixed_phy_status ncsi_phy_status = {
+ .link = 1,
+ .speed = SPEED_100,
+ .duplex = DUPLEX_FULL,
+ .pause = 0,
+ .asym_pause = 0
+};
+
struct ftgmac100 {
/* Registers */
struct resource *res;
@@ -1492,19 +1502,8 @@ static int ftgmac100_open(struct net_device *netdev)
return err;
}
- /* When using NC-SI we force the speed to 100Mbit/s full duplex,
- *
- * Otherwise we leave it set to 0 (no link), the link
- * message from the PHY layer will handle setting it up to
- * something else if needed.
- */
- if (priv->use_ncsi) {
- priv->cur_duplex = DUPLEX_FULL;
- priv->cur_speed = SPEED_100;
- } else {
- priv->cur_duplex = 0;
- priv->cur_speed = 0;
- }
+ priv->cur_duplex = 0;
+ priv->cur_speed = 0;
/* Reset the hardware */
err = ftgmac100_reset_and_config_mac(priv);
@@ -1532,9 +1531,6 @@ static int ftgmac100_open(struct net_device *netdev)
/* If we have a PHY, start polling */
phy_start(netdev->phydev);
} else if (priv->use_ncsi) {
- /* If using NC-SI, set our carrier on and start the stack */
- netif_carrier_on(netdev);
-
/* Start the NCSI device */
err = ncsi_start_dev(priv->ndev);
if (err)
@@ -1794,6 +1790,7 @@ static int ftgmac100_probe(struct platform_device *pdev)
struct net_device *netdev;
struct ftgmac100 *priv;
struct device_node *np;
+ struct phy_device *phydev;
int err = 0;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
@@ -1879,6 +1876,14 @@ static int ftgmac100_probe(struct platform_device *pdev)
err = -EINVAL;
goto err_phy_connect;
}
+
+ phydev = fixed_phy_register(PHY_POLL, &ncsi_phy_status, NULL);
+ err = phy_connect_direct(netdev, phydev, ftgmac100_adjust_link,
+ PHY_INTERFACE_MODE_MII);
+ if (err) {
+ dev_err(&pdev->dev, "Connecting PHY failed\n");
+ goto err_phy_connect;
+ }
} else if (np && of_phy_is_fixed_link(np)) {
struct phy_device *phy;
--
2.25.1
Powered by blists - more mailing lists