linux-kernel - Re: [PATCH RESEND 31/31] ASoC: amd/sdw_utils: add sof based soundwire generic machine driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9383df48-2d72-41a6-978d-3b7217947f54@amd.com>
Date: Fri, 2 Aug 2024 14:15:17 +0530
From: "Mukunda,Vijendar" <vijendar.mukunda@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>, broonie@...nel.org
Cc: Basavaraj.Hiregoudar@....com, Sunil-kumar.Dommati@....com,
 alsa-devel@...a-project.org, pierre-louis.bossart@...ux.intel.com,
 venkataprasad.potturu@....com, yung-chuan.liao@...ux.intel.com,
 linux-sound@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 Syed Saba Kareem <Syed.SabaKareem@....com>, Arnd Bergmann <arnd@...db.de>,
 Marian Postevca <posteuca@...ex.one>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND 31/31] ASoC: amd/sdw_utils: add sof based soundwire
 generic machine driver

On 02/08/24 14:07, Krzysztof Kozlowski wrote:
> On 01/08/2024 13:18, Vijendar Mukunda wrote:
>> Add sof based Soundwire generic driver for amd platforms.
>> Currently support added for ACP6.3 based platforms.
>>
> ...
>
>> +static const struct platform_device_id mc_id_table[] = {
>> +	{ "amd_sof_sdw", },
>> +	{}
>> +};
>> +MODULE_DEVICE_TABLE(platform, mc_id_table);
>> +
>> +static struct platform_driver sof_sdw_driver = {
>> +	.driver = {
>> +		.name = "amd_sof_sdw",
>> +		.pm = &snd_soc_pm_ops,
>> +	},
>> +	.probe = mc_probe,
>> +	.remove_new = mc_remove,
>> +	.id_table = mc_id_table,
>> +};
>> +
>> +module_platform_driver(sof_sdw_driver);
>> +
>> +MODULE_DESCRIPTION("ASoC AMD SoundWire Generic Machine driver");
>> +MODULE_AUTHOR("Vijendar Mukunda <Vijendar.Mukunda@....com");
>> +MODULE_LICENSE("GPL");
>> +MODULE_ALIAS("platform:amd_sof_sdw");
> That's a total duplicate... standard form letter:
>
> You should not need MODULE_ALIAS() in normal cases. If you need it,
> usually it means your device ID table is wrong (e.g. misses either
> entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute
> for incomplete ID table.
Agreed. Will remove MODULE_ALIAS().
>
>
> Best regards,
> Krzysztof
>