[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1c276f68-3568-483c-8f75-88261b180b8d@arm.com>
Date: Fri, 2 Aug 2024 10:35:38 +0100
From: Lukasz Luba <lukasz.luba@....com>
To: "Rafael J. Wysocki" <rjw@...ysocki.net>,
Linux PM <linux-pm@...r.kernel.org>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND][PATCH v1 2/8] thermal: hisi: Use
thermal_zone_for_each_trip() in hisi_thermal_register_sensor()
On 7/29/24 16:56, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>
> Modify hisi_thermal_register_sensor() to use thermal_zone_for_each_trip()
> for walking trip points instead of iterating over trip indices and using
> thermal_zone_get_trip() to get a struct thermal_trip pointer from a trip
> index.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
>
> This patch does not depend on the previous patch(es) in the series.
>
> ---
> drivers/thermal/hisi_thermal.c | 22 +++++++++++++---------
> 1 file changed, 13 insertions(+), 9 deletions(-)
>
> Index: linux-pm/drivers/thermal/hisi_thermal.c
> ===================================================================
> --- linux-pm.orig/drivers/thermal/hisi_thermal.c
> +++ linux-pm/drivers/thermal/hisi_thermal.c
> @@ -465,6 +465,18 @@ static irqreturn_t hisi_thermal_alarm_ir
> return IRQ_HANDLED;
> }
>
> +static int hisi_trip_walk_cb(struct thermal_trip *trip, void *arg)
> +{
> + struct hisi_thermal_sensor *sensor = arg;
> +
> + if (trip->type != THERMAL_TRIP_PASSIVE)
> + return 0;
> +
> + sensor->thres_temp = trip->temperature;
> + /* Return nonzero to terminate the search. */
> + return 1;
> +}
> +
> static int hisi_thermal_register_sensor(struct platform_device *pdev,
> struct hisi_thermal_sensor *sensor)
> {
> @@ -482,15 +494,7 @@ static int hisi_thermal_register_sensor(
> return ret;
> }
>
> - for (i = 0; i < thermal_zone_get_num_trips(sensor->tzd); i++) {
> -
> - thermal_zone_get_trip(sensor->tzd, i, &trip);
> -
> - if (trip.type == THERMAL_TRIP_PASSIVE) {
> - sensor->thres_temp = trip.temperature;
> - break;
> - }
> - }
> + thermal_zone_for_each_trip(sensor->tzd, hisi_trip_walk_cb, sensor);
>
> return 0;
> }
>
>
>
Reviewed-by: Lukasz Luba <lukasz.luba@....com>
Powered by blists - more mailing lists