linux-kernel - Re: [PATCH] net: ath9k: use devm for gpio_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y15f6y7o.fsf@toke.dk>
Date: Fri, 02 Aug 2024 12:00:43 +0200
From: Toke Høiland-Jørgensen <toke@...nel.org>
To: Rosen Penev <rosenp@...il.com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ath9k: use devm for gpio_request_one

Rosen Penev <rosenp@...il.com> writes:

> On Thu, Aug 1, 2024 at 1:26 AM Toke Høiland-Jørgensen <toke@...nel.org> wrote:
>>
>> Rosen Penev <rosenp@...il.com> writes:
>>
>> > No need to manually free the gpio now.
>> >
>> > Remove if statement as it's redundant now. The gpio bit now gets cleared
>> > whether set or not.
>> >
>> > Signed-off-by: Rosen Penev <rosenp@...il.com>
>>
>> So presumably these will conflict with this patch?
>>
>> https://patchwork.kernel.org/project/linux-wireless/patch/3b46f6c7-4372-4cc9-9a7c-2c1c06d29324@gmail.com/
> This does not look related.

Ah, no, you're right; was confusing the PCI-internal device managed
thing with the generic one :)

-Toke