[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240802113629.00003069@Huawei.com>
Date: Fri, 2 Aug 2024 11:36:29 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Mike Rapoport <rppt@...nel.org>
CC: <linux-kernel@...r.kernel.org>, Alexander Gordeev
<agordeev@...ux.ibm.com>, Andreas Larsson <andreas@...sler.com>, "Andrew
Morton" <akpm@...ux-foundation.org>, Arnd Bergmann <arnd@...db.de>, "Borislav
Petkov" <bp@...en8.de>, Catalin Marinas <catalin.marinas@....com>, Christophe
Leroy <christophe.leroy@...roup.eu>, Dan Williams <dan.j.williams@...el.com>,
Dave Hansen <dave.hansen@...ux.intel.com>, David Hildenbrand
<david@...hat.com>, "David S. Miller" <davem@...emloft.net>, Davidlohr Bueso
<dave@...olabs.net>, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, Heiko
Carstens <hca@...ux.ibm.com>, Huacai Chen <chenhuacai@...nel.org>, Ingo
Molnar <mingo@...hat.com>, Jiaxun Yang <jiaxun.yang@...goat.com>, "John Paul
Adrian Glaubitz" <glaubitz@...sik.fu-berlin.de>, Jonathan Corbet
<corbet@....net>, Michael Ellerman <mpe@...erman.id.au>, Palmer Dabbelt
<palmer@...belt.com>, "Rafael J. Wysocki" <rafael@...nel.org>, Rob Herring
<robh@...nel.org>, Samuel Holland <samuel.holland@...ive.com>, Thomas
Bogendoerfer <tsbogend@...ha.franken.de>, Thomas Gleixner
<tglx@...utronix.de>, "Vasily Gorbik" <gor@...ux.ibm.com>, Will Deacon
<will@...nel.org>, Zi Yan <ziy@...dia.com>, <devicetree@...r.kernel.org>,
<linux-acpi@...r.kernel.org>, <linux-arch@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>, <linux-cxl@...r.kernel.org>,
<linux-doc@...r.kernel.org>, <linux-mips@...r.kernel.org>,
<linux-mm@...ck.org>, <linux-riscv@...ts.infradead.org>,
<linux-s390@...r.kernel.org>, <linux-sh@...r.kernel.org>,
<linuxppc-dev@...ts.ozlabs.org>, <loongarch@...ts.linux.dev>,
<nvdimm@...ts.linux.dev>, <sparclinux@...r.kernel.org>, <x86@...nel.org>
Subject: Re: [PATCH v3 11/26] x86/numa: use get_pfn_range_for_nid to verify
that node spans memory
On Thu, 1 Aug 2024 09:08:11 +0300
Mike Rapoport <rppt@...nel.org> wrote:
> From: "Mike Rapoport (Microsoft)" <rppt@...nel.org>
>
> Instead of looping over numa_meminfo array to detect node's start and
> end addresses use get_pfn_range_for_init().
>
> This is shorter and make it easier to lift numa_memblks to generic code.
>
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@...nel.org>
> Tested-by: Zi Yan <ziy@...dia.com> # for x86_64 and arm64
Fair enough given code a few lines up has set the node
for all the memblocks so this should I think give the same
effective result.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> ---
> arch/x86/mm/numa.c | 13 +++----------
> 1 file changed, 3 insertions(+), 10 deletions(-)
>
> diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c
> index edfc38803779..cfe7e5477cf8 100644
> --- a/arch/x86/mm/numa.c
> +++ b/arch/x86/mm/numa.c
> @@ -521,17 +521,10 @@ static int __init numa_register_memblks(struct numa_meminfo *mi)
>
> /* Finally register nodes. */
> for_each_node_mask(nid, node_possible_map) {
> - u64 start = PFN_PHYS(max_pfn);
> - u64 end = 0;
> + unsigned long start_pfn, end_pfn;
>
> - for (i = 0; i < mi->nr_blks; i++) {
> - if (nid != mi->blk[i].nid)
> - continue;
> - start = min(mi->blk[i].start, start);
> - end = max(mi->blk[i].end, end);
> - }
> -
> - if (start >= end)
> + get_pfn_range_for_nid(nid, &start_pfn, &end_pfn);
> + if (start_pfn >= end_pfn)
> continue;
>
> alloc_node_data(nid);
Powered by blists - more mailing lists