linux-kernel - Re: [PATCH] irqchip: let the probe of APLIC be earlier than IMSIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mslv19ff.ffs@tglx>
Date: Fri, 02 Aug 2024 12:55:00 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Vincent Chen <vincent.chen@...ive.com>, anup@...infault.org
Cc: paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu,
 linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
 vincent.chen@...ive.com
Subject: Re: [PATCH] irqchip: let the probe of APLIC be earlier than IMSIC

On Fri, Aug 02 2024 at 15:57, Vincent Chen wrote:
> When the debug message of driver/base/dd.c is enabled, the following
> error messages are present in the boot log:
>
> [    0.207941] platform d000000.aplic: error -EPROBE_DEFER: supplier
> 28000000.imsics not ready
> [    0.208115] platform d000000.aplic: Added to deferred list

Deferred probing is not an error.

> The reason for this error message is that the probe of APLIC is executed
> earlier than IMSIC. This error also causes all the platform devices
> connected to the APLIC to be added to the deferred list. Because both
> APLIC and IMSIC are registered by device_initcall, this patch adjusts the
> compile order of APLIC and IMSIC to ensure that the probe of IMSIC is
> executed earlier than the probe of APLIC.

And no we are not playing silly ordering games just to suppress a debug
output.

Thanks,

        tglx