linux-kernel - Re: [PATCH v3 21/26] mm: numa_memblks: make several functions and variables static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240802121010.00000113@Huawei.com>
Date: Fri, 2 Aug 2024 12:10:10 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Mike Rapoport <rppt@...nel.org>
CC: <linux-kernel@...r.kernel.org>, Alexander Gordeev
	<agordeev@...ux.ibm.com>, Andreas Larsson <andreas@...sler.com>, "Andrew
 Morton" <akpm@...ux-foundation.org>, Arnd Bergmann <arnd@...db.de>, "Borislav
 Petkov" <bp@...en8.de>, Catalin Marinas <catalin.marinas@....com>, Christophe
 Leroy <christophe.leroy@...roup.eu>, Dan Williams <dan.j.williams@...el.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>, David Hildenbrand
	<david@...hat.com>, "David S. Miller" <davem@...emloft.net>, Davidlohr Bueso
	<dave@...olabs.net>, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, Heiko
 Carstens <hca@...ux.ibm.com>, Huacai Chen <chenhuacai@...nel.org>, Ingo
 Molnar <mingo@...hat.com>, Jiaxun Yang <jiaxun.yang@...goat.com>, "John Paul
 Adrian Glaubitz" <glaubitz@...sik.fu-berlin.de>, Jonathan Corbet
	<corbet@....net>, Michael Ellerman <mpe@...erman.id.au>, Palmer Dabbelt
	<palmer@...belt.com>, "Rafael J. Wysocki" <rafael@...nel.org>, Rob Herring
	<robh@...nel.org>, Samuel Holland <samuel.holland@...ive.com>, Thomas
 Bogendoerfer <tsbogend@...ha.franken.de>, Thomas Gleixner
	<tglx@...utronix.de>, "Vasily Gorbik" <gor@...ux.ibm.com>, Will Deacon
	<will@...nel.org>, Zi Yan <ziy@...dia.com>, <devicetree@...r.kernel.org>,
	<linux-acpi@...r.kernel.org>, <linux-arch@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-cxl@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, <linux-mips@...r.kernel.org>,
	<linux-mm@...ck.org>, <linux-riscv@...ts.infradead.org>,
	<linux-s390@...r.kernel.org>, <linux-sh@...r.kernel.org>,
	<linuxppc-dev@...ts.ozlabs.org>, <loongarch@...ts.linux.dev>,
	<nvdimm@...ts.linux.dev>, <sparclinux@...r.kernel.org>, <x86@...nel.org>
Subject: Re: [PATCH v3 21/26] mm: numa_memblks: make several functions and
 variables static

On Thu,  1 Aug 2024 09:08:21 +0300
Mike Rapoport <rppt@...nel.org> wrote:

> From: "Mike Rapoport (Microsoft)" <rppt@...nel.org>
> 
> Make functions and variables that are exclusively used by numa_memblks
> static.
> 
> Move numa_nodemask_from_meminfo() before its callers to avoid forward
> declaration.
> 
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@...nel.org>
> Tested-by: Zi Yan <ziy@...dia.com> # for x86_64 and arm64
Good. I was wondering why some of this internal detail was in the header.
Much nicer after this.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>